mirror of
https://github.com/danog/psalm.git
synced 2025-01-22 13:51:54 +01:00
b47306ad3b
Probably for legacy reasons, PDOException::getCode() can return string (it's an SQLSTATE code). Note that if you instantiate it yourself, you will get an integer though. I changed the signature of the Exception stub accordingly, and then there were errors about incompatible signatures, so I had to change the signature of Throwable too, which makes sense since a Throwable could be a PDOException. The signature at https://www.php.net/manual/en/throwable.getcode.php seems plain wrong, and that same page of the docs warns about PDOException. Not sure what are the plans for future versions of PHP.