mirror of
https://github.com/danog/psalm.git
synced 2024-11-27 04:45:20 +01:00
734 lines
20 KiB
PHP
734 lines
20 KiB
PHP
<?php
|
|
namespace Psalm\Tests;
|
|
|
|
use PhpParser\ParserFactory;
|
|
use PHPUnit_Framework_TestCase;
|
|
use Psalm\Checker\FileChecker;
|
|
use Psalm\Config;
|
|
use Psalm\Context;
|
|
|
|
class ScopeTest extends PHPUnit_Framework_TestCase
|
|
{
|
|
/** @var \PhpParser\Parser */
|
|
protected static $parser;
|
|
|
|
/** @var \Psalm\Checker\ProjectChecker */
|
|
protected $project_checker;
|
|
protected static $file_filter;
|
|
|
|
public static function setUpBeforeClass()
|
|
{
|
|
self::$parser = (new ParserFactory)->create(ParserFactory::PREFER_PHP7);
|
|
|
|
$config = new TestConfig();
|
|
}
|
|
|
|
public function setUp()
|
|
{
|
|
FileChecker::clearCache();
|
|
$this->project_checker = new \Psalm\Checker\ProjectChecker();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage PossiblyUndefinedVariable - somefile.php:6 - Possibly undefined variable $b, first seen
|
|
* on line 3
|
|
*/
|
|
public function testPossiblyUndefinedVarInIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (rand(0,100) === 10) {
|
|
$b = "s";
|
|
}
|
|
|
|
echo $b;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testNewVarInIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (rand(0,100) === 10) {
|
|
$badge = "hello";
|
|
}
|
|
else {
|
|
$badge = "goodbye";
|
|
}
|
|
|
|
echo $badge;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testNewVarInIfWithElseReturn()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (rand(0,100) === 10) {
|
|
$badge = "hello";
|
|
}
|
|
else {
|
|
throw new \Exception();
|
|
}
|
|
|
|
echo $badge;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage PossiblyUndefinedVariable - somefile.php:3 - Possibly undefined variable $array, first
|
|
* seen on line 3
|
|
*/
|
|
public function testPossiblyUndefinedArrayInIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (rand(0,100) === 10) {
|
|
$array[] = "hello";
|
|
}
|
|
|
|
echo $array;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage PossiblyUndefinedVariable - somefile.php:3 - Possibly undefined variable $array, first
|
|
* seen on line 3
|
|
*/
|
|
public function testPossiblyUndefinedArrayInForeach()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
foreach ([1, 2, 3, 4] as $b) {
|
|
$array[] = "hello";
|
|
}
|
|
|
|
echo $array;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage PossiblyUndefinedVariable - somefile.php:4 - Possibly undefined variable $array, first
|
|
* seen on line 4
|
|
*/
|
|
public function testPossiblyUndefinedArrayInWhileAndForeach()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
for ($i = 0; $i < 4; $i++) {
|
|
while (rand(0,10) === 5) {
|
|
$array[] = "hello";
|
|
}
|
|
}
|
|
|
|
echo $array;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage PossiblyUndefinedVariable - somefile.php:6 - Possibly undefined variable $car, first
|
|
* seen on line 3
|
|
*/
|
|
public function testPossiblyUndefinedVariableInForeach()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
foreach ([1, 2, 3, 4] as $b) {
|
|
$car = "Volvo";
|
|
}
|
|
|
|
echo $car;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testSwitchVariableWithContinue()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
foreach ([\'a\', \'b\', \'c\'] as $letter) {
|
|
switch ($letter) {
|
|
case \'a\':
|
|
$foo = 1;
|
|
break;
|
|
case \'b\':
|
|
$foo = 2;
|
|
break;
|
|
default:
|
|
continue;
|
|
}
|
|
|
|
$moo = $foo;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testSwitchVariableWithContinueAndIfs()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
foreach ([\'a\', \'b\', \'c\'] as $letter) {
|
|
switch ($letter) {
|
|
case \'a\':
|
|
if (rand(0, 10) === 1) {
|
|
continue;
|
|
}
|
|
$foo = 1;
|
|
break;
|
|
case \'b\':
|
|
if (rand(0, 10) === 1) {
|
|
continue;
|
|
}
|
|
$foo = 2;
|
|
break;
|
|
default:
|
|
continue;
|
|
}
|
|
|
|
$moo = $foo;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testSwitchVariableWithFallthrough()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
foreach ([\'a\', \'b\', \'c\'] as $letter) {
|
|
switch ($letter) {
|
|
case \'a\':
|
|
case \'b\':
|
|
$foo = 2;
|
|
break;
|
|
|
|
default:
|
|
$foo = 3;
|
|
break;
|
|
}
|
|
|
|
$moo = $foo;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testSwitchVariableWithFallthroughStatement()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
foreach ([\'a\', \'b\', \'c\'] as $letter) {
|
|
switch ($letter) {
|
|
case \'a\':
|
|
$bar = 1;
|
|
|
|
case \'b\':
|
|
$foo = 2;
|
|
break;
|
|
|
|
default:
|
|
$foo = 3;
|
|
break;
|
|
}
|
|
|
|
$moo = $foo;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testTryCatchVar()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
try {
|
|
$worked = true;
|
|
}
|
|
catch (\Exception $e) {
|
|
$worked = false;
|
|
}
|
|
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$context = new Context('somefile.php');
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
|
$this->assertEquals('bool', (string) $context->vars_in_scope['$worked']);
|
|
}
|
|
|
|
public function testWhileVar()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
|
|
$worked = false;
|
|
|
|
while (rand(0,100) === 10) {
|
|
$worked = true;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$context = new Context('somefile.php');
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
|
$this->assertEquals('bool', (string) $context->vars_in_scope['$worked']);
|
|
}
|
|
|
|
public function testDoWhileVar()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$worked = false;
|
|
|
|
do {
|
|
$worked = true;
|
|
}
|
|
while (rand(0,100) === 10);
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$context = new Context('somefile.php');
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
|
$this->assertEquals('bool', (string) $context->vars_in_scope['$worked']);
|
|
}
|
|
|
|
public function testAssignmentInIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if ($row = (rand(0, 10) ? [5] : null)) {
|
|
echo $row[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testNegatedAssignmentInIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (!($row = (rand(0, 10) ? [5] : null))) {
|
|
// do nothing
|
|
}
|
|
else {
|
|
echo $row[0];
|
|
}
|
|
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testAssignInElseIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (rand(0, 10) > 5) {
|
|
echo "hello";
|
|
} elseif ($row = (rand(0, 10) ? [5] : null)) {
|
|
echo $row[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testIfNotEqualsFalse()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (($row = rand(0,10) ? [1] : false) !== false) {
|
|
echo $row[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testIfNotEqualsNull()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (($row = rand(0,10) ? [1] : null) !== null) {
|
|
echo $row[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testIfNullNotEquals()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (null !== ($row = rand(0,10) ? [1] : null)) {
|
|
echo $row[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testIfNullEquals()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (null === ($row = rand(0,10) ? [1] : null)) {
|
|
|
|
} else {
|
|
echo $row[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testPassByRefInIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (preg_match("/bad/", "badger", $matches)) {
|
|
echo (string)$matches[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testPassByRefInIfCheckAfter()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (!preg_match("/bad/", "badger", $matches)) {
|
|
exit();
|
|
}
|
|
echo (string)$matches[0];
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testPassByRefInIfWithBoolean()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = true;
|
|
if ($a && preg_match("/bad/", "badger", $matches)) {
|
|
echo (string)$matches[0];
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage PossiblyUndefinedVariable - somefile.php:9 - Possibly undefined variable $a, first
|
|
* seen on line 4
|
|
*/
|
|
public function testPossiblyUndefinedVariableInForeachAndIf()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
foreach ([1,2,3,4] as $i) {
|
|
if ($i === 1) {
|
|
$a = true;
|
|
break;
|
|
}
|
|
}
|
|
|
|
echo $a;
|
|
');
|
|
|
|
Config::getInstance()->setIssueHandler('PossiblyUndefinedVariable', self::$file_filter);
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testFunctionExists()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
if (true && function_exists("flabble")) {
|
|
flabble();
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testNestedPropertyFetchInElseif()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
class A {
|
|
/** @var A|null */
|
|
public $foo;
|
|
|
|
public function __toString() : string {
|
|
return "boop";
|
|
}
|
|
}
|
|
|
|
$a = rand(0, 10) === 5 ? new A() : null;
|
|
|
|
if (false) {
|
|
|
|
}
|
|
elseif ($a && $a->foo) {
|
|
echo $a;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testGlobalReturn()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$foo = "foo";
|
|
|
|
function a() : string {
|
|
global $foo;
|
|
|
|
return $foo;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testStatic()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
function a() : string {
|
|
static $foo = "foo";
|
|
|
|
return $foo;
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage InvalidGlobal
|
|
*/
|
|
public function testInvalidGlobal()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = "heli";
|
|
|
|
global $a;
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage InvalidStaticVariable
|
|
*/
|
|
public function testThisInStatic()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
class A {
|
|
public static function fooFoo() {
|
|
echo $this;
|
|
}
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testTwoVarLogic()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = rand(0, 10) ? "hello" : null;
|
|
$b = rand(0, 10) ? "goodbye" : null;
|
|
|
|
if ($a !== null || $b !== null) {
|
|
if ($a !== null) {
|
|
$c = $a;
|
|
} else {
|
|
$c = $b;
|
|
}
|
|
|
|
echo strpos($c, "e");
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testThreeVarLogic()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = rand(0, 10) ? "hello" : null;
|
|
$b = rand(0, 10) ? "goodbye" : null;
|
|
$c = rand(0, 10) ? "hello" : null;
|
|
|
|
if ($a !== null || $b !== null || $c !== null) {
|
|
if ($a !== null) {
|
|
$d = $a;
|
|
} elseif ($b !== null) {
|
|
$d = $b;
|
|
} else {
|
|
$d = $c;
|
|
}
|
|
|
|
echo strpos($d, "e");
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage NullArgument
|
|
*/
|
|
public function testThreeVarLogicWithChange()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = rand(0, 10) ? "hello" : null;
|
|
$b = rand(0, 10) ? "goodbye" : null;
|
|
$c = rand(0, 10) ? "hello" : null;
|
|
|
|
if ($a !== null || $b !== null || $c !== null) {
|
|
$c = null;
|
|
|
|
if ($a !== null) {
|
|
$d = $a;
|
|
} elseif ($b !== null) {
|
|
$d = $b;
|
|
} else {
|
|
$d = $c;
|
|
}
|
|
|
|
echo strpos($d, "e");
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
/**
|
|
* @expectedException \Psalm\Exception\CodeException
|
|
* @expectedExceptionMessage NullArgument
|
|
*/
|
|
public function testThreeVarLogicWithException()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = rand(0, 10) ? "hello" : null;
|
|
$b = rand(0, 10) ? "goodbye" : null;
|
|
$c = rand(0, 10) ? "hello" : null;
|
|
|
|
if ($a !== null || $b !== null || $c !== null) {
|
|
if ($c !== null) {
|
|
throw new \Exception("bad");
|
|
}
|
|
|
|
if ($a !== null) {
|
|
$d = $a;
|
|
} elseif ($b !== null) {
|
|
$d = $b;
|
|
} else {
|
|
$d = $c;
|
|
}
|
|
|
|
echo strpos($d, "e");
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$file_checker->visitAndAnalyzeMethods();
|
|
}
|
|
|
|
public function testNegateAssertionAndOther()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = rand(0, 10) ? "hello" : null;
|
|
|
|
if (rand(0, 10) > 1 && is_string($a)) {
|
|
throw new \Exception("bad");
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$context = new Context('somefile.php');
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
|
$this->assertEquals('string|null', (string) $context->vars_in_scope['$a']);
|
|
}
|
|
|
|
public function testRepeatAssertionWithOther()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
$a = rand(0, 10) ? "hello" : null;
|
|
|
|
if (rand(0, 10) > 1 || is_string($a)) {
|
|
if (is_string($a)) {
|
|
echo strpos("e", $a);
|
|
}
|
|
}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$context = new Context('somefile.php');
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
|
$this->assertEquals('string|null', (string) $context->vars_in_scope['$a']);
|
|
}
|
|
|
|
public function testRefineORedType()
|
|
{
|
|
$stmts = self::$parser->parse('<?php
|
|
class A {
|
|
public function doThing() : void
|
|
{
|
|
if ($this instanceof B || $this instanceof C) {
|
|
if ($this instanceof B) {
|
|
|
|
}
|
|
}
|
|
}
|
|
}
|
|
class B extends A {}
|
|
class C extends A {}
|
|
');
|
|
|
|
$file_checker = new FileChecker('somefile.php', $this->project_checker, $stmts);
|
|
$context = new Context('somefile.php');
|
|
$file_checker->visitAndAnalyzeMethods($context);
|
|
}
|
|
}
|