mirror of
https://github.com/danog/psalm.git
synced 2024-11-27 12:55:26 +01:00
Daniil Gentili
1986c8b4a8
* Immutable CodeLocation * Remove excess clones * Remove external clones * Remove leftover clones * Fix final clone issue * Immutable storages * Refactoring * Fixes * Fixes * Fix * Fix * Fixes * Simplify * Fixes * Fix * Fixes * Update * Fix * Cache global types * Fix * Update * Update * Fixes * Fixes * Refactor * Fixes * Fix * Fix * More caching * Fix * Fix * Update * Update * Fix * Fixes * Update * Refactor * Update * Fixes * Break one more test * Fix * FIx * Fix * Fix * Fix * Fix * Improve performance and readability * Equivalent logic * Fixes * Revert * Revert "Revert" This reverts commit f9175100c8452c80559234200663fd4c4f4dd889. * Fix * Fix reference bug * Make default TypeVisitor immutable * Bugfix * Remove clones * Partial refactoring * Refactoring * Fixes * Fix * Fixes * Fixes * cs-fix * Fix final bugs * Add test * Misc fixes * Update * Fixes * Experiment with removing different property * revert "Experiment with removing different property" This reverts commit ac1156e077fc4ea633530d51096d27b6e88bfdf9. * Uniform naming * Uniform naming * Hack hotfix * Clean up $_FILES ref #8621 * Undo hack, try fixing properly * Helper method * Remove redundant call * Partially fix bugs * Cleanup * Change defaults * Fix bug * Fix (?, hope this doesn't break anything else) * cs-fix * Review fixes * Bugfix * Bugfix * Improve logic * Add support for list{} and callable-list{} types, properly implement array_is_list assertions (fixes #8389) * Default to sealed arrays * Fix array_merge bug * Fixes * Fix * Sealed type checks * Properly infer properties-of and get_object_vars on final classes * Fix array_map zipping * Fix tests * Fixes * Fixes * Fix more stuff * Recursively resolve type aliases * Fix typo * Fixes * Fix array_is_list assertion on keyed array * Add BC docs * Fixes * fix * Update * Update * Update * Update * Seal arrays with count assertions * Fix #8528 * Fix * Update * Improve sealed array foreach logic * get_object_vars on template properties * Fix sealed array assertion reconciler logic * Improved reconciler * Add tests * Single source of truth for test types * Fix tests * Fixup tests * Fixup tests * Fixup tests * Update * Fix tests * Fix tests * Final fixes * Fixes * Use list syntax only when needed * Fix tests * Cs-fix * Update docs * Update docs * Update docs * Update docs * Update docs * Document missing types * Update docs * Improve class-string-map docs * Update * Update * I love working on psalm :) * Keep arrays unsealed by default * Fixup tests * Fix syntax mistake * cs-fix * Fix typo * Re-import missing types * Keep strict types only in return types * argc/argv fixes * argc/argv fixes * Fix test * Comment-out valinor code, pinging @romm pls merge https://github.com/CuyZ/Valinor/pull/246 so we can add valinor to the psalm docs :)
170 lines
5.1 KiB
PHP
170 lines
5.1 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
namespace Psalm\Tests;
|
|
|
|
use Psalm\Tests\Traits\InvalidCodeAnalysisTestTrait;
|
|
use Psalm\Tests\Traits\ValidCodeAnalysisTestTrait;
|
|
|
|
class CloneTest extends TestCase
|
|
{
|
|
use InvalidCodeAnalysisTestTrait;
|
|
use ValidCodeAnalysisTestTrait;
|
|
|
|
/**
|
|
*
|
|
*/
|
|
public function providerValidCodeParse(): iterable
|
|
{
|
|
return [
|
|
'cloneCorrect' => [
|
|
'code' => '<?php
|
|
class A {}
|
|
function foo(A $a) : A {
|
|
return clone $a;
|
|
}
|
|
$a = foo(new A());',
|
|
],
|
|
'cloneCorrectWithPublicMethod' => [
|
|
'code' => '<?php
|
|
class A {
|
|
public function __clone() {}
|
|
}
|
|
function foo(A $a) : A {
|
|
return clone $a;
|
|
}
|
|
foo(new A());',
|
|
],
|
|
'clonePrivateInternally' => [
|
|
'code' => '<?php
|
|
class A {
|
|
private function __clone() {}
|
|
public function foo(): self {
|
|
return clone $this;
|
|
}
|
|
}',
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
*
|
|
*/
|
|
public function providerInvalidCodeParse(): iterable
|
|
{
|
|
return [
|
|
'invalidIntClone' => [
|
|
'code' => '<?php
|
|
$a = 5;
|
|
clone $a;',
|
|
'error_message' => 'InvalidClone',
|
|
],
|
|
'possiblyInvalidIntClone' => [
|
|
'code' => '<?php
|
|
$a = rand(0, 1) ? 5 : new Exception();
|
|
clone $a;',
|
|
'error_message' => 'PossiblyInvalidClone',
|
|
],
|
|
'invalidMixedClone' => [
|
|
'code' => '<?php
|
|
/** @var mixed $a */
|
|
$a = 5;
|
|
clone $a;',
|
|
'error_message' => 'MixedClone',
|
|
],
|
|
'notVisibleCloneMethod' => [
|
|
'code' => '<?php
|
|
class A {
|
|
private function __clone() {}
|
|
}
|
|
$a = new A();
|
|
clone $a;',
|
|
'error_message' => 'InvalidClone',
|
|
],
|
|
'notVisibleCloneMethodSubClass' => [
|
|
'code' => '<?php
|
|
class a {
|
|
private function __clone() {}
|
|
}
|
|
class b extends a {}
|
|
|
|
clone new b;',
|
|
'error_message' => 'InvalidClone',
|
|
],
|
|
'notVisibleCloneMethodTrait' => [
|
|
'code' => '<?php
|
|
trait a {
|
|
private function __clone() {}
|
|
}
|
|
class b {
|
|
use a;
|
|
}
|
|
|
|
clone new b;',
|
|
'error_message' => 'InvalidClone',
|
|
],
|
|
'invalidGenericClone' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @template T as int|string
|
|
* @param T $a
|
|
*/
|
|
function foo($a): void {
|
|
clone $a;
|
|
}',
|
|
'error_message' => 'InvalidClone',
|
|
],
|
|
'possiblyInvalidGenericClone' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @template T as int|Exception
|
|
* @param T $a
|
|
*/
|
|
function foo($a): void {
|
|
clone $a;
|
|
}',
|
|
'error_message' => 'PossiblyInvalidClone',
|
|
],
|
|
'mixedGenericClone' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @template T
|
|
* @param T $a
|
|
*/
|
|
function foo($a): void {
|
|
clone $a;
|
|
}',
|
|
'error_message' => 'MixedClone',
|
|
],
|
|
'mixedTypeInferredIfErrors' => [
|
|
'code' => '<?php
|
|
class A {}
|
|
/**
|
|
* @param A|string $a
|
|
*/
|
|
function foo($a): void {
|
|
/**
|
|
* @psalm-suppress PossiblyInvalidClone
|
|
*/
|
|
$cloned = clone $a;
|
|
}',
|
|
'error_message' => 'MixedAssignment',
|
|
],
|
|
'missingClass' => [
|
|
'code' => '<?php
|
|
/**
|
|
* @psalm-suppress UndefinedDocblockClass
|
|
* @psalm-suppress InvalidReturnType
|
|
* @return Editable
|
|
*/
|
|
function get() {}
|
|
|
|
/** @psalm-suppress UndefinedDocblockClass */
|
|
clone get();',
|
|
'error_message' => 'InvalidClone',
|
|
],
|
|
];
|
|
}
|
|
}
|