mirror of
https://github.com/danog/psalm.git
synced 2024-11-26 20:34:47 +01:00
dabfb16e34
* Run tests in random order Being able to run tests in any order is a pre-requisite for being able to run them in parallel. * Reset type coverage between tests, fix affected tests * Reset parser and lexer between test runs and on php version change Previously lexer was reset, but parser kept the reference to the old one, and reference to the parser was kept by StatementsProvider. This resulted in order-dependent tests - if the parser was first initialized with phpVersion set to 7.4 then arrow functions worked fine, but were failing when the parser was initially constructed with settings for 7.3 This can be demonstrated on current master by upgrading to nikic/php-parser:4.9 and running: ``` vendor/bin/phpunit --no-coverage --filter="inferredArgArrowFunction" tests/ClosureTest.php ``` Now all tests using PHP 7.4 features must set the PHP version accordingly. * Marked more tests using 7.4 syntax * Reset newline-between-annotation flag between tests * Resolve real paths before passing them to checkPaths When checkPaths is called from psalm.php the paths are resolved, so we just mimicking SUT behaviour here. * Restore newline-between-annotations in DocCommentTest * Tweak Appveyor caches * Tweak TravisCI caches * Tweak CircleCI caches * Run tests in parallel Use `vendor/bin/paratest` instead of `vendor/bin/phpunit` * Use default paratest runner on Windows WrapperRunner is not supported on Windows. * TRAVIS_TAG could be empty * Restore appveyor conditional caching
700 lines
25 KiB
PHP
700 lines
25 KiB
PHP
<?php
|
|
|
|
namespace Psalm\Tests;
|
|
|
|
use DOMDocument;
|
|
use Psalm\Context;
|
|
use Psalm\Internal\Analyzer\FileAnalyzer;
|
|
use Psalm\Internal\Analyzer\ProjectAnalyzer;
|
|
use Psalm\Internal\RuntimeCaches;
|
|
use Psalm\IssueBuffer;
|
|
use Psalm\Report;
|
|
use Psalm\Report\JsonReport;
|
|
use Psalm\Tests\Internal\Provider;
|
|
|
|
use function file_get_contents;
|
|
use function json_decode;
|
|
use function ob_end_clean;
|
|
use function ob_start;
|
|
use function preg_replace;
|
|
use function array_values;
|
|
use function unlink;
|
|
|
|
class ReportOutputTest extends TestCase
|
|
{
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function setUp() : void
|
|
{
|
|
// `TestCase::setUp()` creates its own ProjectAnalyzer and Config instance, but we don't want to do that in this
|
|
// case, so don't run a `parent::setUp()` call here.
|
|
RuntimeCaches::clearAll();
|
|
$this->file_provider = new Provider\FakeFileProvider();
|
|
|
|
$config = new TestConfig();
|
|
$config->throw_exception = false;
|
|
$config->setCustomErrorLevel('PossiblyUndefinedGlobalVariable', \Psalm\Config::REPORT_INFO);
|
|
|
|
$json_report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.json']);
|
|
|
|
$this->project_analyzer = new ProjectAnalyzer(
|
|
$config,
|
|
new \Psalm\Internal\Provider\Providers(
|
|
$this->file_provider,
|
|
new Provider\FakeParserCacheProvider()
|
|
),
|
|
new Report\ReportOptions(),
|
|
$json_report_options
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testReportFormatValid()
|
|
{
|
|
$config = new TestConfig();
|
|
$config->throw_exception = false;
|
|
|
|
// No exception
|
|
foreach (['.xml', '.txt', '.json', '.emacs'] as $extension) {
|
|
ProjectAnalyzer::getFileReportOptions(['/tmp/report' . $extension]);
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testReportFormatException()
|
|
{
|
|
$this->expectException(\UnexpectedValueException::class);
|
|
$config = new TestConfig();
|
|
$config->throw_exception = false;
|
|
|
|
ProjectAnalyzer::getFileReportOptions(['/tmp/report.log']);
|
|
}
|
|
|
|
public function analyzeFileForReport() : void
|
|
{
|
|
$file_contents = '<?php
|
|
function psalmCanVerify(int $your_code): ?string {
|
|
return $as_you_____type;
|
|
}
|
|
|
|
// and it supports PHP 5.4 - 7.1
|
|
echo CHANGE_ME;
|
|
|
|
if (rand(0, 100) > 10) {
|
|
$a = 5;
|
|
} else {
|
|
//$a = 2;
|
|
}
|
|
|
|
echo $a;';
|
|
|
|
$this->addFile(
|
|
'somefile.php',
|
|
$file_contents
|
|
);
|
|
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testJsonReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$issue_data = [
|
|
[
|
|
'severity' => 'error',
|
|
'line_from' => 3,
|
|
'line_to' => 3,
|
|
'type' => 'UndefinedVariable',
|
|
'message' => 'Cannot find referenced variable $as_you_____type',
|
|
'file_name' => 'somefile.php',
|
|
'file_path' => 'somefile.php',
|
|
'snippet' => ' return $as_you_____type;',
|
|
'selected_text' => '$as_you_____type',
|
|
'from' => 66,
|
|
'to' => 82,
|
|
'snippet_from' => 57,
|
|
'snippet_to' => 83,
|
|
'column_from' => 10,
|
|
'column_to' => 26,
|
|
'error_level' => -1,
|
|
'shortcode' => 24,
|
|
'link' => 'https://psalm.dev/024',
|
|
'taint_trace' => null
|
|
],
|
|
[
|
|
'severity' => 'error',
|
|
'line_from' => 3,
|
|
'line_to' => 3,
|
|
'type' => 'MixedReturnStatement',
|
|
'message' => 'Could not infer a return type',
|
|
'file_name' => 'somefile.php',
|
|
'file_path' => 'somefile.php',
|
|
'snippet' => ' return $as_you_____type;',
|
|
'selected_text' => '$as_you_____type',
|
|
'from' => 66,
|
|
'to' => 82,
|
|
'snippet_from' => 57,
|
|
'snippet_to' => 83,
|
|
'column_from' => 10,
|
|
'column_to' => 26,
|
|
'error_level' => 1,
|
|
'shortcode' => 138,
|
|
'link' => 'https://psalm.dev/138',
|
|
'taint_trace' => null
|
|
],
|
|
[
|
|
'severity' => 'error',
|
|
'line_from' => 2,
|
|
'line_to' => 2,
|
|
'type' => 'MixedInferredReturnType',
|
|
'message' => 'Could not verify return type \'null|string\' for psalmCanVerify',
|
|
'file_name' => 'somefile.php',
|
|
'file_path' => 'somefile.php',
|
|
'snippet' => 'function psalmCanVerify(int $your_code): ?string {',
|
|
'selected_text' => '?string',
|
|
'from' => 47,
|
|
'to' => 54,
|
|
'snippet_from' => 6,
|
|
'snippet_to' => 56,
|
|
'column_from' => 42,
|
|
'column_to' => 49,
|
|
'error_level' => 1,
|
|
'shortcode' => 47,
|
|
'link' => 'https://psalm.dev/047',
|
|
'taint_trace' => null
|
|
],
|
|
[
|
|
'severity' => 'error',
|
|
'line_from' => 7,
|
|
'line_to' => 7,
|
|
'type' => 'UndefinedConstant',
|
|
'message' => 'Const CHANGE_ME is not defined',
|
|
'file_name' => 'somefile.php',
|
|
'file_path' => 'somefile.php',
|
|
'snippet' => 'echo CHANGE_ME;',
|
|
'selected_text' => 'CHANGE_ME',
|
|
'from' => 125,
|
|
'to' => 134,
|
|
'snippet_from' => 120,
|
|
'snippet_to' => 135,
|
|
'column_from' => 6,
|
|
'column_to' => 15,
|
|
'error_level' => -1,
|
|
'shortcode' => 20,
|
|
'link' => 'https://psalm.dev/020',
|
|
'taint_trace' => null
|
|
],
|
|
[
|
|
'severity' => 'info',
|
|
'line_from' => 15,
|
|
'line_to' => 15,
|
|
'type' => 'PossiblyUndefinedGlobalVariable',
|
|
'message' => 'Possibly undefined global variable $a, first seen on line 10',
|
|
'file_name' => 'somefile.php',
|
|
'file_path' => 'somefile.php',
|
|
'snippet' => 'echo $a',
|
|
'selected_text' => '$a',
|
|
'from' => 201,
|
|
'to' => 203,
|
|
'snippet_from' => 196,
|
|
'snippet_to' => 203,
|
|
'column_from' => 6,
|
|
'column_to' => 8,
|
|
'error_level' => 3,
|
|
'shortcode' => 126,
|
|
'link' => 'https://psalm.dev/126',
|
|
'taint_trace' => null
|
|
],
|
|
];
|
|
|
|
$json_report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.json'])[0];
|
|
|
|
$this->assertSame(
|
|
array_values($issue_data),
|
|
json_decode(IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $json_report_options), true)
|
|
);
|
|
}
|
|
|
|
public function testFilteredJsonReportIsStillArray(): void
|
|
{
|
|
$issues_data = [
|
|
22 => new \Psalm\Internal\Analyzer\IssueData(
|
|
'info',
|
|
15,
|
|
15,
|
|
'PossiblyUndefinedGlobalVariable',
|
|
'Possibly undefined global variable $a, first seen on line 10',
|
|
'somefile.php',
|
|
'somefile.php',
|
|
'echo $a',
|
|
'$a',
|
|
201,
|
|
203,
|
|
196,
|
|
203,
|
|
6,
|
|
8
|
|
),
|
|
];
|
|
|
|
$report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.json'])[0];
|
|
$fixable_issue_counts = ['MixedInferredReturnType' => 1];
|
|
|
|
$report = new JsonReport(
|
|
$issues_data,
|
|
$fixable_issue_counts,
|
|
$report_options
|
|
);
|
|
$this->assertIsArray(json_decode($report->create()));
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testSonarqubeReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$issue_data = [
|
|
'issues' => [
|
|
[
|
|
'engineId' => 'Psalm',
|
|
'ruleId' => 'UndefinedVariable',
|
|
'primaryLocation' => [
|
|
'message' => 'Cannot find referenced variable $as_you_____type',
|
|
'filePath' => 'somefile.php',
|
|
'textRange' => [
|
|
'startLine' => 3,
|
|
'endLine' => 3,
|
|
'startColumn' => 9,
|
|
'endColumn' => 25,
|
|
],
|
|
],
|
|
'type' => 'CODE_SMELL',
|
|
'severity' => 'CRITICAL',
|
|
],
|
|
[
|
|
'engineId' => 'Psalm',
|
|
'ruleId' => 'MixedReturnStatement',
|
|
'primaryLocation' => [
|
|
'message' => 'Could not infer a return type',
|
|
'filePath' => 'somefile.php',
|
|
'textRange' => [
|
|
'startLine' => 3,
|
|
'endLine' => 3,
|
|
'startColumn' => 9,
|
|
'endColumn' => 25,
|
|
],
|
|
],
|
|
'type' => 'CODE_SMELL',
|
|
'severity' => 'CRITICAL',
|
|
],
|
|
[
|
|
'engineId' => 'Psalm',
|
|
'ruleId' => 'MixedInferredReturnType',
|
|
'primaryLocation' => [
|
|
'message' => 'Could not verify return type \'null|string\' for psalmCanVerify',
|
|
'filePath' => 'somefile.php',
|
|
'textRange' => [
|
|
'startLine' => 2,
|
|
'endLine' => 2,
|
|
'startColumn' => 41,
|
|
'endColumn' => 48,
|
|
],
|
|
],
|
|
'type' => 'CODE_SMELL',
|
|
'severity' => 'CRITICAL',
|
|
],
|
|
[
|
|
'engineId' => 'Psalm',
|
|
'ruleId' => 'UndefinedConstant',
|
|
'primaryLocation' => [
|
|
'message' => 'Const CHANGE_ME is not defined',
|
|
'filePath' => 'somefile.php',
|
|
'textRange' => [
|
|
'startLine' => 7,
|
|
'endLine' => 7,
|
|
'startColumn' => 5,
|
|
'endColumn' => 14,
|
|
],
|
|
],
|
|
'type' => 'CODE_SMELL',
|
|
'severity' => 'CRITICAL',
|
|
],
|
|
[
|
|
'engineId' => 'Psalm',
|
|
'ruleId' => 'PossiblyUndefinedGlobalVariable',
|
|
'primaryLocation' => [
|
|
'message' => 'Possibly undefined global variable $a, first seen on line 10',
|
|
'filePath' => 'somefile.php',
|
|
'textRange' => [
|
|
'startLine' => 15,
|
|
'endLine' => 15,
|
|
'startColumn' => 5,
|
|
'endColumn' => 7,
|
|
],
|
|
],
|
|
'type' => 'CODE_SMELL',
|
|
'severity' => 'MINOR',
|
|
],
|
|
],
|
|
];
|
|
|
|
$sonarqube_report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-sonarqube.json'])[0];
|
|
$sonarqube_report_options->format = 'sonarqube';
|
|
|
|
$this->assertSame(
|
|
$issue_data,
|
|
json_decode(IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $sonarqube_report_options), true)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testEmacsReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$emacs_report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.emacs'])[0];
|
|
|
|
$this->assertSame(
|
|
'somefile.php:3:10:error - Cannot find referenced variable $as_you_____type
|
|
somefile.php:3:10:error - Could not infer a return type
|
|
somefile.php:2:42:error - Could not verify return type \'null|string\' for psalmCanVerify
|
|
somefile.php:7:6:error - Const CHANGE_ME is not defined
|
|
somefile.php:15:6:warning - Possibly undefined global variable $a, first seen on line 10
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $emacs_report_options)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testPylintReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$pylint_report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.pylint'])[0];
|
|
|
|
$this->assertSame(
|
|
'somefile.php:3: [E0001] UndefinedVariable: Cannot find referenced variable $as_you_____type (column 10)
|
|
somefile.php:3: [E0001] MixedReturnStatement: Could not infer a return type (column 10)
|
|
somefile.php:2: [E0001] MixedInferredReturnType: Could not verify return type \'null|string\' for psalmCanVerify (column 42)
|
|
somefile.php:7: [E0001] UndefinedConstant: Const CHANGE_ME is not defined (column 6)
|
|
somefile.php:15: [W0001] PossiblyUndefinedGlobalVariable: Possibly undefined global variable $a, first seen on line 10 (column 6)
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $pylint_report_options)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testConsoleReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$console_report_options = new Report\ReportOptions();
|
|
$console_report_options->use_color = false;
|
|
|
|
$this->assertSame(
|
|
'ERROR: UndefinedVariable - somefile.php:3:10 - Cannot find referenced variable $as_you_____type (see https://psalm.dev/024)
|
|
return $as_you_____type;
|
|
|
|
ERROR: MixedReturnStatement - somefile.php:3:10 - Could not infer a return type (see https://psalm.dev/138)
|
|
return $as_you_____type;
|
|
|
|
ERROR: MixedInferredReturnType - somefile.php:2:42 - Could not verify return type \'null|string\' for psalmCanVerify (see https://psalm.dev/047)
|
|
function psalmCanVerify(int $your_code): ?string {
|
|
|
|
ERROR: UndefinedConstant - somefile.php:7:6 - Const CHANGE_ME is not defined (see https://psalm.dev/020)
|
|
echo CHANGE_ME;
|
|
|
|
INFO: PossiblyUndefinedGlobalVariable - somefile.php:15:6 - Possibly undefined global variable $a, first seen on line 10 (see https://psalm.dev/126)
|
|
echo $a
|
|
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $console_report_options)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testConsoleReportNoInfo()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$console_report_options = new Report\ReportOptions();
|
|
$console_report_options->use_color = false;
|
|
$console_report_options->show_info = false;
|
|
|
|
$this->assertSame(
|
|
'ERROR: UndefinedVariable - somefile.php:3:10 - Cannot find referenced variable $as_you_____type (see https://psalm.dev/024)
|
|
return $as_you_____type;
|
|
|
|
ERROR: MixedReturnStatement - somefile.php:3:10 - Could not infer a return type (see https://psalm.dev/138)
|
|
return $as_you_____type;
|
|
|
|
ERROR: MixedInferredReturnType - somefile.php:2:42 - Could not verify return type \'null|string\' for psalmCanVerify (see https://psalm.dev/047)
|
|
function psalmCanVerify(int $your_code): ?string {
|
|
|
|
ERROR: UndefinedConstant - somefile.php:7:6 - Const CHANGE_ME is not defined (see https://psalm.dev/020)
|
|
echo CHANGE_ME;
|
|
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $console_report_options)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testConsoleReportNoSnippet()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$console_report_options = new Report\ReportOptions();
|
|
$console_report_options->show_snippet = false;
|
|
$console_report_options->use_color = false;
|
|
|
|
$this->assertSame(
|
|
'ERROR: UndefinedVariable - somefile.php:3:10 - Cannot find referenced variable $as_you_____type (see https://psalm.dev/024)
|
|
|
|
|
|
ERROR: MixedReturnStatement - somefile.php:3:10 - Could not infer a return type (see https://psalm.dev/138)
|
|
|
|
|
|
ERROR: MixedInferredReturnType - somefile.php:2:42 - Could not verify return type \'null|string\' for psalmCanVerify (see https://psalm.dev/047)
|
|
|
|
|
|
ERROR: UndefinedConstant - somefile.php:7:6 - Const CHANGE_ME is not defined (see https://psalm.dev/020)
|
|
|
|
|
|
INFO: PossiblyUndefinedGlobalVariable - somefile.php:15:6 - Possibly undefined global variable $a, first seen on line 10 (see https://psalm.dev/126)
|
|
|
|
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $console_report_options)
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testCompactReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$compact_report_options = new Report\ReportOptions();
|
|
$compact_report_options->format = Report::TYPE_COMPACT;
|
|
$compact_report_options->use_color = false;
|
|
|
|
$this->assertSame(
|
|
'FILE: somefile.php' . "\n" .
|
|
"\n" .
|
|
'+----------+------+---------------------------------+---------------------------------------------------------------+' . "\n" .
|
|
'| SEVERITY | LINE | ISSUE | DESCRIPTION |' . "\n" .
|
|
'+----------+------+---------------------------------+---------------------------------------------------------------+' . "\n" .
|
|
'| ERROR | 3 | UndefinedVariable | Cannot find referenced variable $as_you_____type |' . "\n" .
|
|
'| ERROR | 3 | MixedReturnStatement | Could not infer a return type |' . "\n" .
|
|
'| ERROR | 2 | MixedInferredReturnType | Could not verify return type \'null|string\' for psalmCanVerify |' . "\n" .
|
|
'| ERROR | 7 | UndefinedConstant | Const CHANGE_ME is not defined |' . "\n" .
|
|
'| INFO | 15 | PossiblyUndefinedGlobalVariable | Possibly undefined global variable $a, first seen on line 10 |' . "\n" .
|
|
'+----------+------+---------------------------------+---------------------------------------------------------------+' . "\n",
|
|
$this->toUnixLineEndings(IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $compact_report_options))
|
|
);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testCheckstyleReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$checkstyle_report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.checkstyle.xml'])[0];
|
|
|
|
$this->assertSame(
|
|
'<?xml version="1.0" encoding="UTF-8"?>
|
|
<checkstyle>
|
|
<file name="somefile.php">
|
|
<error line="3" column="10" severity="error" message="UndefinedVariable: Cannot find referenced variable $as_you_____type"/>
|
|
</file>
|
|
<file name="somefile.php">
|
|
<error line="3" column="10" severity="error" message="MixedReturnStatement: Could not infer a return type"/>
|
|
</file>
|
|
<file name="somefile.php">
|
|
<error line="2" column="42" severity="error" message="MixedInferredReturnType: Could not verify return type \'null|string\' for psalmCanVerify"/>
|
|
</file>
|
|
<file name="somefile.php">
|
|
<error line="7" column="6" severity="error" message="UndefinedConstant: Const CHANGE_ME is not defined"/>
|
|
</file>
|
|
<file name="somefile.php">
|
|
<error line="15" column="6" severity="info" message="PossiblyUndefinedGlobalVariable: Possibly undefined global variable $a, first seen on line 10"/>
|
|
</file>
|
|
</checkstyle>
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $checkstyle_report_options)
|
|
);
|
|
|
|
// FIXME: The XML parser only return strings, all int value are casted, so the assertSame failed
|
|
//$this->assertSame(
|
|
// ['report' => ['item' => $issue_data]],
|
|
// XML2Array::createArray(IssueBuffer::getOutput(ProjectAnalyzer::TYPE_XML, false), LIBXML_NOCDATA)
|
|
//);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testJunitReport()
|
|
{
|
|
$this->analyzeFileForReport();
|
|
|
|
$checkstyle_report_options = ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.junit.xml'])[0];
|
|
|
|
$xml = IssueBuffer::getOutput(IssueBuffer::getIssuesData(), $checkstyle_report_options);
|
|
|
|
$this->assertSame(
|
|
'<?xml version="1.0" encoding="UTF-8"?>
|
|
<testsuites failures="4" errors="0" name="psalm" tests="5" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://raw.githubusercontent.com/junit-team/junit5/r5.5.1/platform-tests/src/test/resources/jenkins-junit.xsd">
|
|
<testsuite name="somefile.php" failures="4" errors="0" tests="5">
|
|
<testcase name="somefile.php:3" classname="UndefinedVariable" assertions="1">
|
|
<failure type="UndefinedVariable">message: Cannot find referenced variable $as_you_____type
|
|
type: UndefinedVariable
|
|
snippet: return $as_you_____type;
|
|
selected_text: $as_you_____type
|
|
line: 3
|
|
column_from: 10
|
|
column_to: 26
|
|
</failure>
|
|
</testcase>
|
|
<testcase name="somefile.php:3" classname="MixedReturnStatement" assertions="1">
|
|
<failure type="MixedReturnStatement">message: Could not infer a return type
|
|
type: MixedReturnStatement
|
|
snippet: return $as_you_____type;
|
|
selected_text: $as_you_____type
|
|
line: 3
|
|
column_from: 10
|
|
column_to: 26
|
|
</failure>
|
|
</testcase>
|
|
<testcase name="somefile.php:2" classname="MixedInferredReturnType" assertions="1">
|
|
<failure type="MixedInferredReturnType">message: Could not verify return type \'null|string\' for psalmCanVerify
|
|
type: MixedInferredReturnType
|
|
snippet: function psalmCanVerify(int $your_code): ?string {
|
|
selected_text: ?string
|
|
line: 2
|
|
column_from: 42
|
|
column_to: 49
|
|
</failure>
|
|
</testcase>
|
|
<testcase name="somefile.php:7" classname="UndefinedConstant" assertions="1">
|
|
<failure type="UndefinedConstant">message: Const CHANGE_ME is not defined
|
|
type: UndefinedConstant
|
|
snippet: echo CHANGE_ME;
|
|
selected_text: CHANGE_ME
|
|
line: 7
|
|
column_from: 6
|
|
column_to: 15
|
|
</failure>
|
|
</testcase>
|
|
<testcase name="somefile.php:15" classname="PossiblyUndefinedGlobalVariable" assertions="1">
|
|
<skipped>message: Possibly undefined global variable $a, first seen on line 10
|
|
type: PossiblyUndefinedGlobalVariable
|
|
snippet: echo $a
|
|
selected_text: $a
|
|
line: 15
|
|
column_from: 6
|
|
column_to: 8
|
|
</skipped>
|
|
</testcase>
|
|
</testsuite>
|
|
</testsuites>
|
|
',
|
|
$xml
|
|
);
|
|
|
|
// Validate against junit xsd
|
|
$dom = new DOMDocument('1.0', 'UTF-8');
|
|
$dom->preserveWhiteSpace = false;
|
|
$dom->loadXML($xml);
|
|
|
|
// Validate against xsd
|
|
$valid = $dom->schemaValidate(__DIR__ . '/junit.xsd');
|
|
$this->assertTrue($valid, 'Output did not validate against XSD');
|
|
|
|
// FIXME: The XML parser only return strings, all int value are casted, so the assertSame failed
|
|
//$this->assertSame(
|
|
// ['report' => ['item' => $issue_data]],
|
|
// XML2Array::createArray(IssueBuffer::getOutput(ProjectAnalyzer::TYPE_XML, false), LIBXML_NOCDATA)
|
|
//);
|
|
}
|
|
|
|
/**
|
|
* @return void
|
|
*/
|
|
public function testEmptyReportIfNotError()
|
|
{
|
|
$this->addFile(
|
|
'somefile.php',
|
|
'<?php ?>'
|
|
);
|
|
|
|
$this->analyzeFile('somefile.php', new Context());
|
|
$this->assertSame(
|
|
'[]
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.json'])[0])
|
|
);
|
|
$this->assertSame(
|
|
'',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.emacs'])[0])
|
|
);
|
|
$this->assertSame(
|
|
'<?xml version="1.0" encoding="UTF-8"?>
|
|
<report>
|
|
<item/>
|
|
</report>
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.xml'])[0])
|
|
);
|
|
|
|
$this->assertSame(
|
|
'<?xml version="1.0" encoding="UTF-8"?>
|
|
<checkstyle>
|
|
</checkstyle>
|
|
',
|
|
IssueBuffer::getOutput(IssueBuffer::getIssuesData(), ProjectAnalyzer::getFileReportOptions([__DIR__ . '/test-report.checkstyle.xml'])[0])
|
|
);
|
|
|
|
ob_start();
|
|
IssueBuffer::finish($this->project_analyzer, true, 0);
|
|
ob_end_clean();
|
|
$this->assertFileExists(__DIR__ . '/test-report.json');
|
|
$this->assertSame('[]
|
|
', file_get_contents(__DIR__ . '/test-report.json'));
|
|
unlink(__DIR__ . '/test-report.json');
|
|
}
|
|
|
|
/**
|
|
* Needed when running on Windows
|
|
*/
|
|
private function toUnixLineEndings(string $output): string
|
|
{
|
|
return preg_replace('~\r\n?~', "\n", $output);
|
|
}
|
|
}
|