mirror of
https://github.com/danog/psalm.git
synced 2024-11-27 04:45:20 +01:00
e29dd140e3
* Add failing test * Add visitor to soup up classlike references * Move a whole bunch of code into the visitor * Move some methods back, move onto analysis stage * Use the getAliases method everywhere * Fix refs * Fix more refs * Fix some tests * Fix more tests * Fix include tests * Shift config class finding to project checker and fix bugs * Fix a few more tests * transition test to new syntax * Remove var_dump * Delete a bunch of code and fix mutation test * Remove unnecessary visitation * Transition to better mocked out file provider, breaking some cached statement loading * Use different scheme for naming anonymous classes * Fix anonymous class issues * Refactor file/statement loading * Add specific property types * Fix mapped property assignment * Improve how we deal with traits * Fix trait checking * Pass Psalm checks * Add multi-process support * Delay console output until the end * Remove PHP 7 syntax * Update file storage with classes * Fix scanning individual files and add reflection return types * Always turn XDebug off * Add quicker method of getting method mutations * Queue return types for crawling * Interpret all strings as possible classes once we see a `get_class` call * Check invalid return types again * Fix template namespacing issues * Default to class-insensitive file names for includes * Don’t overwrite existing issues data * Add var docblocks for scanning * Add null check * Fix loading of external classes in templates * Only try to populate class when we haven’t yet seen it’s not a class * Fix trait property accessibility * Only ever improve docblock param type * Make param replacement more robust * Fix static const missing inferred type * Fix a few more tests * Register constant definitions * Fix trait aliasing * Skip constant type tests for now * Fix linting issues * Make sure caching is off for tests * Remove unnecessary return * Use emulative parser if on PHP 5.6 * Cache parser for faster first-time parse * Fix constant resolution when scanning classes * Remove test that’s beyond a practical scope * Add back --diff support * Add --help for --threads * Remove unused vars
267 lines
8.8 KiB
PHP
267 lines
8.8 KiB
PHP
<?php
|
|
namespace Psalm\Tests;
|
|
|
|
use Psalm\Checker\FileChecker;
|
|
|
|
class IncludeTest extends TestCase
|
|
{
|
|
/**
|
|
* @dataProvider providerTestValidIncludes
|
|
*
|
|
* @param array<int, string> $files_to_check
|
|
* @param array<string, string> $files
|
|
*
|
|
* @return void
|
|
*/
|
|
public function testValidInclude(array $files, array $files_to_check)
|
|
{
|
|
foreach ($files as $filename => $contents) {
|
|
$this->addFile($filename, $contents);
|
|
$this->project_checker->registerAnalyzableFile($filename);
|
|
}
|
|
|
|
$this->project_checker->scanFiles();
|
|
|
|
foreach ($files_to_check as $filename) {
|
|
$file_checker = new FileChecker($filename, $this->project_checker);
|
|
$file_checker->analyze();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @dataProvider providerTestInvalidIncludes
|
|
*
|
|
* @param array<int, string> $files_to_check
|
|
* @param array<string, string> $files
|
|
* @param mixed $error_message
|
|
*
|
|
* @return void
|
|
*/
|
|
public function testInvalidInclude(array $files, array $files_to_check, $error_message)
|
|
{
|
|
foreach ($files as $filename => $contents) {
|
|
$this->addFile($filename, $contents);
|
|
$this->project_checker->registerAnalyzableFile($filename);
|
|
}
|
|
|
|
$this->project_checker->scanFiles();
|
|
|
|
$this->expectException('\Psalm\Exception\CodeException');
|
|
$this->expectExceptionMessage($error_message);
|
|
|
|
foreach ($files_to_check as $filename) {
|
|
$file_checker = new FileChecker($filename, $this->project_checker);
|
|
$file_checker->analyze();
|
|
}
|
|
}
|
|
|
|
/**
|
|
* @return array
|
|
*/
|
|
public function providerTestValidIncludes()
|
|
{
|
|
return [
|
|
'basicRequire' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require("file1.php");
|
|
|
|
class B {
|
|
public function foo() : void {
|
|
(new A)->fooFoo();
|
|
}
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
class A{
|
|
public function fooFoo() : void {
|
|
|
|
}
|
|
}',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php',
|
|
],
|
|
],
|
|
'nestedRequire' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
class A{
|
|
public function fooFoo() : void {
|
|
|
|
}
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require("file1.php");
|
|
|
|
class B extends A{
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file3.php' => '<?php
|
|
require("file2.php");
|
|
|
|
class C extends B {
|
|
public function doFoo() : void {
|
|
$this->fooFoo();
|
|
}
|
|
}',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file3.php',
|
|
],
|
|
],
|
|
'requireNamespace' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
namespace Foo;
|
|
|
|
class A{
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require("file1.php");
|
|
|
|
class B {
|
|
public function foo() : void {
|
|
(new Foo\A);
|
|
}
|
|
}',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php',
|
|
],
|
|
],
|
|
'requireFunction' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
function fooFoo() : void {
|
|
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require("file1.php");
|
|
|
|
fooFoo();',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php',
|
|
],
|
|
],
|
|
'requireNamespacedWithUse' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
namespace Foo;
|
|
|
|
class A{
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require("file1.php");
|
|
|
|
use Foo\A;
|
|
|
|
class B {
|
|
public function foo() : void {
|
|
(new A);
|
|
}
|
|
}',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php',
|
|
],
|
|
],
|
|
'noInfiniteRequireLoop' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
require_once("file2.php");
|
|
require_once("file3.php");
|
|
|
|
class B extends A {
|
|
public function doFoo() : void {
|
|
$this->fooFoo();
|
|
}
|
|
}
|
|
|
|
class C {}
|
|
|
|
new D();',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require_once("file3.php");
|
|
|
|
class A{
|
|
public function fooFoo() : void { }
|
|
}
|
|
|
|
new C();',
|
|
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file3.php' => '<?php
|
|
require_once("file1.php");
|
|
|
|
class D{ }
|
|
|
|
new C();',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file3.php',
|
|
],
|
|
],
|
|
'analyzeAllClasses' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
require_once("file2.php");
|
|
class B extends A {
|
|
public function doFoo() : void {
|
|
$this->fooFoo();
|
|
}
|
|
}
|
|
class C {
|
|
public function barBar() : void { }
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require_once("file1.php");
|
|
class A{
|
|
public function fooFoo() : void { }
|
|
}
|
|
class D extends C {
|
|
public function doBar() : void {
|
|
$this->barBar();
|
|
}
|
|
}',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php',
|
|
],
|
|
],
|
|
];
|
|
}
|
|
|
|
/**
|
|
* @return array
|
|
*/
|
|
public function providerTestInvalidIncludes()
|
|
{
|
|
return [
|
|
'undefinedMethodInRequire' => [
|
|
'files' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php' => '<?php
|
|
require("file1.php");
|
|
|
|
class B {
|
|
public function foo() : void {
|
|
(new A)->fooFo();
|
|
}
|
|
}',
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file1.php' => '<?php
|
|
class A{
|
|
public function fooFoo() : void {
|
|
|
|
}
|
|
}',
|
|
],
|
|
'files_to_check' => [
|
|
getcwd() . DIRECTORY_SEPARATOR . 'file2.php',
|
|
],
|
|
'error_message' => 'UndefinedMethod',
|
|
],
|
|
];
|
|
}
|
|
}
|