1
0
mirror of https://github.com/danog/psalm.git synced 2025-01-22 13:51:54 +01:00
psalm/tests/TraitTest.php
Matthew Brown e29dd140e3 Refactor scanning and analysis, introducing multithreading (#191)
* Add failing test

* Add visitor to soup up classlike references

* Move a whole bunch of code into the visitor

* Move some methods back, move onto analysis stage

* Use the getAliases method everywhere

* Fix refs

* Fix more refs

* Fix some tests

* Fix more tests

* Fix include tests

* Shift config class finding to project checker and fix bugs

* Fix a few more tests

* transition test to new syntax

* Remove var_dump

* Delete a bunch of code and fix mutation test

* Remove unnecessary visitation

* Transition to better mocked out file provider, breaking some cached statement loading

* Use different scheme for naming anonymous classes

* Fix anonymous class issues

* Refactor file/statement loading

* Add specific property types

* Fix mapped property assignment

* Improve how we deal with traits

* Fix trait checking

* Pass Psalm checks

* Add multi-process support

* Delay console output until the end

* Remove PHP 7 syntax

* Update file storage with classes

* Fix scanning individual files and add reflection return types

* Always turn XDebug off

* Add quicker method of getting method mutations

* Queue return types for crawling

* Interpret all strings as possible classes once we see a `get_class` call

* Check invalid return types again

* Fix template namespacing issues

* Default to class-insensitive file names for includes

* Don’t overwrite existing issues data

* Add var docblocks for scanning

* Add null check

* Fix loading of external classes in templates

* Only try to populate class when we haven’t yet seen it’s not a class

* Fix trait property accessibility

* Only ever improve docblock param type

* Make param replacement more robust

* Fix static const missing inferred type

* Fix a few more tests

* Register constant definitions

* Fix trait aliasing

* Skip constant type tests for now

* Fix linting issues

* Make sure caching is off for tests

* Remove unnecessary return

* Use emulative parser if on PHP 5.6

* Cache parser for faster first-time parse

* Fix constant resolution when scanning classes

* Remove test that’s beyond a practical scope

* Add back --diff support

* Add --help for --threads

* Remove unused vars
2017-07-25 16:11:02 -04:00

419 lines
12 KiB
PHP

<?php
namespace Psalm\Tests;
class TraitTest extends TestCase
{
use Traits\FileCheckerInvalidCodeParseTestTrait;
use Traits\FileCheckerValidCodeParseTestTrait;
/**
* @return array
*/
public function providerFileCheckerValidCodeParse()
{
return [
'accessiblePrivateMethodFromTrait' => [
'<?php
trait T {
private function fooFoo() : void {
}
}
class B {
use T;
public function doFoo() : void {
$this->fooFoo();
}
}',
],
'accessibleProtectedMethodFromTrait' => [
'<?php
trait T {
protected function fooFoo() : void {
}
}
class B {
use T;
public function doFoo() : void {
$this->fooFoo();
}
}',
],
'accessiblePublicMethodFromTrait' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
public function doFoo() : void {
$this->fooFoo();
}
}',
],
'accessiblePrivatePropertyFromTrait' => [
'<?php
trait T {
/** @var string */
private $fooFoo = "";
}
class B {
use T;
public function doFoo() : void {
echo $this->fooFoo;
$this->fooFoo = "hello";
}
}',
],
'accessibleProtectedPropertyFromTrait' => [
'<?php
trait T {
/** @var string */
protected $fooFoo = "";
}
class B {
use T;
public function doFoo() : void {
echo $this->fooFoo;
$this->fooFoo = "hello";
}
}',
],
'accessiblePublicPropertyFromTrait' => [
'<?php
trait T {
/** @var string */
public $fooFoo = "";
}
class B {
use T;
public function doFoo() : void {
echo $this->fooFoo;
$this->fooFoo = "hello";
}
}',
],
'accessibleProtectedMethodFromInheritedTrait' => [
'<?php
trait T {
protected function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function doFoo() : void {
$this->fooFoo();
}
}',
],
'accessiblePublicMethodFromInheritedTrait' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function doFoo() : void {
$this->fooFoo();
}
}',
],
'staticClassMethodFromWithinTrait' => [
'<?php
trait T {
public function fooFoo() : void {
self::barBar();
}
}
class B {
use T;
public static function barBar() : void {
}
}',
],
'redefinedTraitMethodWithoutAlias' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
public function fooFoo(string $a) : void {
}
}
(new B)->fooFoo("hello");',
],
'redefinedTraitMethodWithAlias' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T {
fooFoo as barBar;
}
public function fooFoo() : void {
$this->barBar();
}
}',
],
'traitSelf' => [
'<?php
trait T {
public function g(): self
{
return $this;
}
}
class A {
use T;
}
$a = (new A)->g();',
'assertions' => [
'$a' => 'A',
],
],
'parentTraitSelf' => [
'<?php
trait T {
public function g(): self
{
return $this;
}
}
class A {
use T;
}
class B extends A {
}
class C {
use T;
}
$a = (new B)->g();',
'assertions' => [
'$a' => 'A',
],
],
'directStaticCall' => [
'<?php
trait T {
/** @return void */
public static function foo() {}
}
class A {
use T;
/** @return void */
public function bar() {
T::foo();
}
}',
],
'abstractTraitMethod' => [
'<?php
trait T {
/** @return void */
abstract public function foo();
}
abstract class A {
use T;
/** @return void */
public function bar() {
$this->foo();
}
}',
],
'instanceOfTraitUser' => [
'<?php
trait T {
public function f() : void {
if ($this instanceof A) { }
}
}
class A {
use T;
}',
],
'useTraitInClassWithAbstractMethod' => [
'<?php
trait T {
abstract public function foo() : void;
}
class A {
public function foo() : void {}
}',
],
'useTraitInSubclassWithAbstractMethod' => [
'<?php
trait T {
abstract public function foo() : void;
}
abstract class A {
public function foo() : void {}
}
class B extends A {
use T;
}',
],
];
}
/**
* @return array
*/
public function providerFileCheckerInvalidCodeParse()
{
return [
'inaccessiblePrivateMethodFromInheritedTrait' => [
'<?php
trait T {
private function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function doFoo() : void {
$this->fooFoo();
}
}',
'error_message' => 'InaccessibleMethod',
],
'undefinedTrait' => [
'<?php
class B {
use A;
}',
'error_message' => 'UndefinedTrait',
],
'missingPropertyType' => [
'<?php
trait T {
public $foo;
}
class A {
use T;
public function assignToFoo() : void {
$this->foo = 5;
}
}',
'error_message' => 'MissingPropertyType - somefile.php:3 - Property T::$foo does not have a ' .
'declared type - consider null|int',
],
'missingPropertyTypeWithConstructorInit' => [
'<?php
trait T {
public $foo;
}
class A {
use T;
public function __construct() : void {
$this->foo = 5;
}
}',
'error_message' => 'MissingPropertyType - somefile.php:3 - Property T::$foo does not have a ' .
'declared type - consider int',
],
'missingPropertyTypeWithConstructorInitAndNull' => [
'<?php
trait T {
public $foo;
}
class A {
use T;
public function __construct() : void {
$this->foo = 5;
}
public function makeNull() : void {
$this->foo = null;
}
}',
'error_message' => 'MissingPropertyType - somefile.php:3 - Property T::$foo does not have a ' .
'declared type - consider null|int',
],
'missingPropertyTypeWithConstructorInitAndNullDefault' => [
'<?php
trait T {
public $foo = null;
}
class A {
use T;
public function __construct() : void {
$this->foo = 5;
}
}',
'error_message' => 'MissingPropertyType - somefile.php:3 - Property T::$foo does not have a ' .
'declared type - consider int|nul',
],
'redefinedTraitMethodInSubclass' => [
'<?php
trait T {
public function fooFoo() : void {
}
}
class B {
use T;
}
class C extends B {
public function fooFoo(string $a) : void {
}
}',
'error_message' => 'MethodSignatureMismatch',
],
];
}
}