mirror of
https://github.com/danog/psalm.git
synced 2024-12-11 16:59:45 +01:00
fd06167843
The example as-is would currently not flag the following code: ``` public function foo() { $foo = $bad_data; \shell_exec($foo); } ``` Switching it to `bad_data` made it work.
2.2 KiB
2.2 KiB
Custom Taint Sources
You can define your own taint sources with an annotation or a plugin.
Taint source annotation
You can use the annotation @psalm-taint-source <taint-type>
to indicate a function or method that provides user input.
In the below example the input
taint type is specified as a standin for the four input taints text
, html
, sql
and shell
.
/**
* @psalm-taint-source input
*/
function getQueryParam(string $name) : string {}
Custom taint plugin
For example this plugin treats all variables named $bad_data
as taint sources.
<?php
namespace Some\Ns;
use PhpParser;
use Psalm\Codebase;
use Psalm\CodeLocation;
use Psalm\Context;
use Psalm\FileManipulation;
use Psalm\Plugin\Hook\AfterExpressionAnalysisInterface;
use Psalm\StatementsSource;
use Psalm\Type\TaintKindGroup;
class BadSqlTainter implements AfterExpressionAnalysisInterface
{
/**
* Called after an expression has been checked
*
* @param PhpParser\Node\Expr $expr
* @param Context $context
* @param string[] $suppressed_issues
* @param FileManipulation[] $file_replacements
*
* @return void
*/
public static function afterExpressionAnalysis(
PhpParser\Node\Expr $expr,
Context $context,
StatementsSource $statements_source,
Codebase $codebase,
array &$file_replacements = []
) {
if ($expr instanceof PhpParser\Node\Expr\Variable
&& $expr->name === 'bad_data'
) {
$expr_type = $statements_source->getNodeTypeProvider()->getType($expr);
// should be a globally unique id
// you can use its line number/start offset
$expr_identifier = '$bad_data'
. '-' . $statements_source->getFileName()
. ':' . $expr->getAttribute('startFilePos');
if ($expr_type) {
$codebase->addTaintSource(
$expr_type,
$expr_identifier,
TaintKindGroup::ALL_INPUT,
new CodeLocation($statements_source, $expr)
);
}
}
}
}