From 576474cfc53e629d1bbe2353a6af728860f95a9e Mon Sep 17 00:00:00 2001 From: Natalie Weizenbaum Date: Thu, 5 Sep 2019 14:39:50 -0700 Subject: [PATCH] Code review changes --- .../documentation/at-rules/function.html.md.erb | 4 ++-- source/documentation/at-rules/mixin.html.md.erb | 4 ++-- source/documentation/modules.html.md.erb | 17 +++++++---------- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/source/documentation/at-rules/function.html.md.erb b/source/documentation/at-rules/function.html.md.erb index b6d33ea..aeb2a9d 100644 --- a/source/documentation/at-rules/function.html.md.erb +++ b/source/documentation/at-rules/function.html.md.erb @@ -200,8 +200,8 @@ including `$`) to those arguments' values. <% fun_fact do %> If you don't ever pass an argument list to the [`map.keywords()` function][], that argument list won't allow extra keyword arguments. This helps callers of - your function make sure they haven't accidentally written any typos in their - argument names. + your function make sure they haven't accidentally misspelled any argument + names. [`map.keywords()` function]: ../modules/map#keywords <% end %> diff --git a/source/documentation/at-rules/mixin.html.md.erb b/source/documentation/at-rules/mixin.html.md.erb index 4714070..ec20f31 100644 --- a/source/documentation/at-rules/mixin.html.md.erb +++ b/source/documentation/at-rules/mixin.html.md.erb @@ -270,8 +270,8 @@ including `$`) to those arguments' values. <% fun_fact do %> If you don't ever pass an argument list to the [`map.keywords()` function][], that argument list won't allow extra keyword arguments. This helps callers of - your mixin make sure they haven't accidentally written any typos in their - argument names. + your mixin make sure they haven't accidentally misspelled any argument + names. [`map.keywords()` function]: ../modules/map#keywords <% end %> diff --git a/source/documentation/modules.html.md.erb b/source/documentation/modules.html.md.erb index 531f470..1c24c3e 100644 --- a/source/documentation/modules.html.md.erb +++ b/source/documentation/modules.html.md.erb @@ -18,14 +18,14 @@ overview: true Before the Sass module system was introduced, all Sass functions were globally available at all times. Many functions still have global aliases (these are listed in their documentation). The Sass team discourages their use and will - eventually deprecate them, but for now they're still available for - compatibility with older Sass versions and with LibSass (which doesn't support - the module system yet). + eventually deprecate them, but for now they remain available for compatibility + with older Sass versions and with LibSass (which doesn't support the module + system yet). - [A few functions][] are still *only* available globally, either because they - have special evaluation behavior ([`if()`][]) or because they add extra - behavior on top of built-in CSS functions ([`rgb()`][] and [`hsl()`][]). These - will not be deprecated and can be used freely. + [A few functions][] are *only* available globally even in the new module + system, either because they have special evaluation behavior ([`if()`][]) or + because they add extra behavior on top of built-in CSS functions ([`rgb()`][] + and [`hsl()`][]). These will not be deprecated and can be used freely. [a few functions]: #global-functions [`if()`]: #if @@ -57,9 +57,6 @@ overview: true Sass provides the following built-in modules: -* Any function that Sass doesn't recognize as built-in or user-defined is - treated as a [plain CSS function][]. (TODO: find a home for this) - * The [`sass:math` module][] provides functions that operate on [numbers][]. * The [`sass:string` module][] makes it easy to combine, search, or split apart