Fix some missing emojis (#1128)

This commit is contained in:
Alexander Zinchuk 2021-05-31 15:08:58 +03:00
parent 33aaad6bca
commit ea94e70343
8 changed files with 30 additions and 19 deletions

View File

@ -80,10 +80,6 @@ function escapeHtml(textParts: TextPart[]): TextPart[] {
} }
function replaceEmojis(textParts: TextPart[], size: 'big' | 'small', type: 'jsx' | 'html'): TextPart[] { function replaceEmojis(textParts: TextPart[], size: 'big' | 'small', type: 'jsx' | 'html'): TextPart[] {
if (IS_EMOJI_SUPPORTED) {
return textParts;
}
return textParts.reduce((result, part) => { return textParts.reduce((result, part) => {
if (typeof part !== 'string') { if (typeof part !== 'string') {
return [...result, part]; return [...result, part];
@ -101,18 +97,24 @@ function replaceEmojis(textParts: TextPart[], size: 'big' | 'small', type: 'jsx'
); );
if (type === 'jsx') { if (type === 'jsx') {
emojiResult.push( emojiResult.push(
IS_EMOJI_SUPPORTED
? <span className="font-emoji">{emoji}</span>
: (
<img <img
className={className} className={className}
src={`./img-apple-${size === 'big' ? '160' : '64'}/${code}.png`} src={`./img-apple-${size === 'big' ? '160' : '64'}/${code}.png`}
alt={emoji} alt={emoji}
/>, />
),
); );
} }
if (type === 'html') { if (type === 'html') {
emojiResult.push( emojiResult.push(
IS_EMOJI_SUPPORTED
? emoji
// For preventing extra spaces in html // For preventing extra spaces in html
// eslint-disable-next-line max-len // eslint-disable-next-line max-len
`<img draggable="false" class="${className}" src="./img-apple-${size === 'big' ? '160' : '64'}/${code}.png" alt="${emoji}" />`, : `<img draggable="false" class="${className}" src="./img-apple-${size === 'big' ? '160' : '64'}/${code}.png" alt="${emoji}" />`,
); );
} }

View File

@ -257,6 +257,7 @@
padding-bottom: calc(1rem - var(--border-width)); padding-bottom: calc(1rem - var(--border-width));
overflow: hidden; overflow: hidden;
line-height: 1.375rem; line-height: 1.375rem;
font-family: Roboto, -apple-system, "Apple Color Emoji", "Helvetica Neue", sans-serif;
&.overflown { &.overflown {
overflow-y: auto; overflow-y: auto;

View File

@ -18,7 +18,7 @@ import {
} from '../../../api/types'; } from '../../../api/types';
import { EDITABLE_INPUT_ID, SCHEDULED_WHEN_ONLINE } from '../../../config'; import { EDITABLE_INPUT_ID, SCHEDULED_WHEN_ONLINE } from '../../../config';
import { IS_EMOJI_SUPPORTED, IS_VOICE_RECORDING_SUPPORTED, IS_MOBILE_SCREEN } from '../../../util/environment'; import { IS_VOICE_RECORDING_SUPPORTED, IS_MOBILE_SCREEN, IS_EMOJI_SUPPORTED } from '../../../util/environment';
import { import {
selectChat, selectChat,
selectIsChatWithBot, selectIsChatWithBot,
@ -317,7 +317,6 @@ const Composer: FC<OwnProps & StateProps & DispatchProps> = ({
insertHtmlInSelection(newHtml); insertHtmlInSelection(newHtml);
messageInput.dispatchEvent(new Event('input', { bubbles: true })); messageInput.dispatchEvent(new Event('input', { bubbles: true }));
} }
return; return;
} }

View File

@ -21,7 +21,9 @@ const EmojiButton: FC<OwnProps> = ({ emoji, focus, onClick }) => {
onClick={handleClick} onClick={handleClick}
title={`:${emoji.names[0]}:`} title={`:${emoji.names[0]}:`}
> >
{IS_EMOJI_SUPPORTED ? emoji.native : <img src={`/img-apple-64/${emoji.image}.png`} alt="" loading="lazy" />} {IS_EMOJI_SUPPORTED
? <span className="font-emoji">{emoji.native}</span>
: <img src={`/img-apple-64/${emoji.image}.png`} alt="" loading="lazy" />}
</div> </div>
); );
}; };

View File

@ -59,6 +59,8 @@ function parseMarkdown(html: string) {
if (!IS_EMOJI_SUPPORTED) { if (!IS_EMOJI_SUPPORTED) {
// Emojis // Emojis
parsedHtml = parsedHtml.replace(/<img[^>]+alt="([^"]+)"[^>]*>/gm, '$1'); parsedHtml = parsedHtml.replace(/<img[^>]+alt="([^"]+)"[^>]*>/gm, '$1');
} else {
parsedHtml = parsedHtml.replace(/<span\s+class="font-emoji">([^<]*)<\/span>/g, '$1');
} }
// Strip redundant <span> tags // Strip redundant <span> tags
parsedHtml = parsedHtml.replace(/<\/?span([^>]*)?>/g, ''); parsedHtml = parsedHtml.replace(/<\/?span([^>]*)?>/g, '');

View File

@ -3,7 +3,7 @@ let element: HTMLSpanElement | undefined;
export default function calculateAuthorWidth(text: string) { export default function calculateAuthorWidth(text: string) {
if (!element) { if (!element) {
element = document.createElement('span'); element = document.createElement('span');
element.style.font = '400 12px Roboto, "Helvetica Neue", "Apple Color Emoji", sans-serif'; element.style.font = '400 12px Roboto, "Helvetica Neue", sans-serif';
element.style.whiteSpace = 'nowrap'; element.style.whiteSpace = 'nowrap';
element.style.position = 'absolute'; element.style.position = 'absolute';
element.style.left = '-999px'; element.style.left = '-999px';

File diff suppressed because one or more lines are too long

View File

@ -20,7 +20,7 @@ html, body {
margin: 0; margin: 0;
padding: 0; padding: 0;
font-size: 16px; font-size: 16px;
font-family: Roboto, "Helvetica Neue", "Apple Color Emoji", sans-serif; font-family: Roboto, "Helvetica Neue", sans-serif;
color: var(--color-text); color: var(--color-text);
overflow: hidden; overflow: hidden;
@media (max-width: 600px) { @media (max-width: 600px) {
@ -28,6 +28,11 @@ html, body {
} }
} }
.font-emoji {
font-family: "Apple Color Emoji", sans-serif;
font-style: normal;
}
body.cursor-grabbing, body.cursor-grabbing * { body.cursor-grabbing, body.cursor-grabbing * {
cursor: grabbing !important; cursor: grabbing !important;
} }