phabel/php-parser
1
0
Fork 0
mirror of https://github.com/phabelio/PHP-Parser.git synced 2024-12-02 09:27:58 +01:00
Code Issues Projects Releases Wiki Activity

Add Error::getMessageWithColumnInfo()

Browse Source
This commit is contained in:
Nikita Popov 2016-09-30 18:24:43 +02:00
parent c5e0c3d7e2
commit f3c7dc9d89
3 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
bin/php-parse
View File

@ -90,11 +90,7 @@ foreach ($files as $file) {
function formatErrorMessage(PhpParser\Error $e, $code, $withColumnInfo) { function formatErrorMessage(PhpParser\Error $e, $code, $withColumnInfo) {
if ($withColumnInfo && $e->hasColumnInfo()) { if ($withColumnInfo && $e->hasColumnInfo()) {
$startLine = $e->getStartLine(); return $e->getMessageWithColumnInfo($code);
$endLine = $e->getEndLine();
$startColumn = $e->getStartColumn($code);
$endColumn = $e->getEndColumn($code);
return $e->getRawMessage() . " from $startLine:$startColumn to $endLine:$endColumn";
} else { } else {
return $e->getMessage(); return $e->getMessage();
} }

8
lib/PhpParser/Error.php
View File

@ -120,6 +120,14 @@ class Error extends \RuntimeException
return $this->toColumn($code, $this->attributes['endFilePos']); return $this->toColumn($code, $this->attributes['endFilePos']);
} }
public function getMessageWithColumnInfo($code) {
return sprintf(
'%s from %d:%d to %d:%d', $this->getRawMessage(),
$this->getStartLine(), $this->getStartColumn($code),
$this->getEndLine(), $this->getEndColumn($code)
);
}
private function toColumn($code, $pos) { private function toColumn($code, $pos) {
if ($pos > strlen($code)) { if ($pos > strlen($code)) {
throw new \RuntimeException('Invalid position information'); throw new \RuntimeException('Invalid position information');

3
test/PhpParser/CodeParsingTest.php
View File

@ -60,8 +60,7 @@ class CodeParsingTest extends CodeTestAbstract
private function formatErrorMessage(Error $e, $code) { private function formatErrorMessage(Error $e, $code) {
if ($e->hasColumnInfo()) { if ($e->hasColumnInfo()) {
return $e->getRawMessage() . ' from ' . $e->getStartLine() . ':' . $e->getStartColumn($code) return $e->getMessageWithColumnInfo($code);
. ' to ' . $e->getEndLine() . ':' . $e->getEndColumn($code);
} else { } else {
return $e->getMessage(); return $e->getMessage();
} }