Commit Graph

1720 Commits

Author SHA1 Message Date
Natalie Weizenbaum
984e76ef77 Remove type parameters from recursive AST visitors 2021-04-14 17:15:08 -07:00
Natalie Weizenbaum
21e7ec19dc Split Declaration's constructor into two
This doesn't explicitly help null-safety, but it makes the
relationship between `Declaration.value` and `Declaration.children`
more obvious.
2021-04-14 17:15:03 -07:00
Natalie Weizenbaum
ca3c6f5ccc Refactor how style rules interact with at-root
This is more friendly to null-safe code, since we no longer rely on
`_inStyleRule` implying that `_styleRule != null`.
2021-04-12 17:31:11 -07:00
Natalie Weizenbaum
5d0ad6957b Split IfClause into ElseClause
This allows us to be statically explicit about when the expression
does or doesn't exist.
2021-04-12 17:31:11 -07:00
Natalie Weizenbaum
3fa2b1d98a Fix hints and lints 2021-04-12 17:31:11 -07:00
Jennifer Thakar
247cb3d816 Update dependencies to null-safe versions
This also replaces package_resolver with package_config, since
package_resolver is archived and is incompatible with null-safe Dart
packages.
2021-04-12 17:31:09 -07:00
Christophe Coevoet
3d39f22cbf
Use the official setup-dart action (#1242) 2021-03-02 12:32:59 -08:00
Lukasz Kolodziejczyk
84cae191bd
Allow the null safety release of args and watcher (#1238) 2021-02-25 13:45:14 -08:00
Awjin Ahn
ad4a1692a8
Adds RenderOptions to the context of custom functions. (#1236) 2021-02-18 13:48:47 -08:00
Awjin Ahn
94d1fc407b
Update chokidar. (#1235) 2021-02-18 13:15:11 -08:00
Jennifer Thakar
a021ae2974
Update CI and CONTRIBUTING to use Node spec runner (#1237) 2021-02-18 12:54:50 -08:00
Christophe Coevoet
881ff129a2
Use HTTPS links in the readme (#1060) 2021-02-10 12:13:58 -08:00
lukaszkolodziejczyk
1df37b1ee9
Allow the null safety release of stream_transform (#1223) 2021-02-09 16:43:55 -08:00
Natalie Weizenbaum
cebf71b39e
Revert "Limit the version of source_span (#1227)" (#1229)
This reverts commit 8afc238db7. The
upstream bug has been fixed and the fix has been published.
2021-02-05 17:32:17 -08:00
Awjin Ahn
4ea9fff2bb
Let last !default value of @forward...with be commaless. (#1226)
This advances the scanner to the next line even if the !default
identifier is not followed by a comma.
2021-02-04 14:18:19 -08:00
Natalie Weizenbaum
8afc238db7
Limit the version of source_span (#1227)
This is a workaround to get the build working again until
dart-lang/source_span#72 lands.
2021-02-04 13:01:43 -08:00
Natalie Weizenbaum
2682992bd4
Split SassNumber into separate subclasses based on units (#1221)
This allows us to use more efficient implementations in the common
case where numbers don't have complex units.

See #113
2021-02-02 17:37:56 -08:00
Natalie Weizenbaum
e664ea8ee3
Merge pull request #1217 from Mstrodl/patch-5
Bump version
2021-02-01 14:51:40 -08:00
Mary
058cf0e4df
Fix fuzzyAssertRange, RangeError takes ints as min/max 2021-01-29 13:34:31 -05:00
Mary
196992eba3
Merge branch 'master' into patch-5 2021-01-28 09:39:45 -05:00
Natalie Weizenbaum
934bdd556a
Set RangeError.start and .end for color range checks (#1215)
This is useful for sass/dart-sass-embedded#32 because it makes the
range checks easier to deconstruct and reconstruct into useful
embedded error messages.
2021-01-27 15:50:02 -08:00
Mary
5e4756a480
Add 1.32.6 to changelog 2021-01-25 13:34:53 -05:00
Mary
b4c6054cc6
Bump version 2021-01-25 13:33:34 -05:00
Natalie Weizenbaum
27c899e77b
Wait longer before running the Bazel task. (#1212)
This is still consistently failing to see the newly-uploaded npm
package.
2021-01-20 15:55:51 -08:00
Christophe Coevoet
9005c6bed5
Remove useless dev dependency (#1210)
source_span is already a normal dependency of the package.
2021-01-20 11:21:20 -08:00
Natalie Weizenbaum
d5207f8fb6
Merge pull request #1208 from sass/node-api-bugs
Fix a few Node.js API bugs
2021-01-19 20:23:19 -08:00
Natalie Weizenbaum
474956d9a8
Merge branch 'master' into node-api-bugs 2021-01-19 18:38:41 -08:00
Christophe Coevoet
f0720f204d
Implement proper handling of units in for loops (#1200)
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
2021-01-19 18:37:41 -08:00
Mary
9262326e76
Update node_preamble.dart (#1207)
Co-authored-by: Natalie Weizenbaum <nweiz@google.com>
2021-01-19 18:19:32 -08:00
Natalie Weizenbaum
072c5252ca Wrap fiber.yield() calls in runZoned()
This resets the current zone after the fiber returns, where otherwise
it could end up set to a different zone entirely, since Dart's Zone
API is unaware of fibers.

Closes #1204
2021-01-15 16:14:35 -08:00
Natalie Weizenbaum
f93feaf592 Don't try to cast an error to JsError
Dart's runtime understanding of what a "JsError" is isn't sufficient
to make sense of everything that might be thrown by, for example, a
custom function with an error.
2021-01-15 16:14:20 -08:00
Christophe Coevoet
6ea8ce6cf9
Fix the CI to use a PR version of sass-spec (#1201)
The previous implementation contained 2 mistakes:

- there was a mismatch between names of env variables in the workflow
  config and in the script
- the `github.base_ref` property in github actions contains a branch
  name, not a full git ref like `github.ref`
2021-01-13 13:06:56 -08:00
Natalie Weizenbaum
a2d2fe20fd
Wait 30 seconds for the npm package to be available for Bazel (#1202) 2021-01-12 13:59:59 -08:00
Natalie Weizenbaum
e97dd1a279
Merge pull request #1198 from sass/deploy
Fix some deployment infrastructure
2021-01-11 17:41:17 -08:00
Natalie Weizenbaum
19555e9a7a Release 1.32.4 2021-01-11 17:04:09 -08:00
Natalie Weizenbaum
0b877a127d Fix an analysis hint 2021-01-11 17:04:00 -08:00
Natalie Weizenbaum
b9f313295b
Update benchmarks (#1196) 2021-01-11 16:54:14 -08:00
Natalie Weizenbaum
647fc45fcf Fix the condition for deploying to Chocolatey 2021-01-11 16:50:10 -08:00
Natalie Weizenbaum
f3bd9103ed If Yarn can't find the new Sass version immediately, wait 10 seconds 2021-01-11 16:44:51 -08:00
Natalie Weizenbaum
ec8cfb32f9 Use GH_TOKEN and GH_USER for Bazel deploy 2021-01-11 16:37:46 -08:00
Natalie Weizenbaum
0cae33007f
Fix the expected format for GitHub refs (#1197) 2021-01-11 16:11:24 -08:00
Natalie Weizenbaum
ae967c7e6e
Remove lingering references to Travis CI (#1195) 2021-01-11 15:02:36 -08:00
Natalie Weizenbaum
66cb55c76f
Avoid throw/catch in Number.== (#1188)
Throwing and catching exceptions is expensive. Testing this on one
user's number-heavy codebase resulted in a 2x speed improvement.
2021-01-11 13:41:37 -08:00
Natalie Weizenbaum
f58173a75b
Fix startsWith() checks in ci.yml (#1189) 2021-01-08 20:04:57 -08:00
Natalie Weizenbaum
be99885909
Merge pull request #1187 from sass/github_actions-nex3
Migrate the CI to github actions
2021-01-08 17:53:56 -08:00
Natalie Weizenbaum
cf42fbbb34 Wait a tick in a failing test even if polling is disabled
As far as I can tell, the root cause of this failure is just the
Node.js watcher failing to emit an event entirely, so there's not much
more we can do to work around it.
2021-01-08 17:23:50 -08:00
Natalie Weizenbaum
7086ea4c87 Can't reference env in jobs.*.strategy 2021-01-08 17:22:07 -08:00
Natalie Weizenbaum
f0d7a52d27 "name:" -> "uses:" 2021-01-08 17:22:07 -08:00
Natalie Weizenbaum
c1cdabc4a3 Use GH_* instead of GITHUB_* for environment variables
According to [the docs], environment variables may not begin with
`GITHUB_`.

[the docs]: https://docs.github.com/en/free-pro-team@latest/actions/reference/environment-variables#naming-conventions-for-environment-variables
2021-01-08 17:22:07 -08:00
Natalie Weizenbaum
eb66325ddd Style changes 2021-01-08 17:22:07 -08:00