1
0
mirror of https://github.com/danog/psalm.git synced 2024-12-16 03:17:02 +01:00
psalm/src/Psalm/Internal/Analyzer/Statements/Expression/Call/MethodCallAnalyzer.php

410 lines
15 KiB
PHP
Raw Normal View History

2018-01-29 00:29:38 +01:00
<?php
2018-11-06 03:57:36 +01:00
namespace Psalm\Internal\Analyzer\Statements\Expression\Call;
2018-01-29 00:29:38 +01:00
use PhpParser;
2018-11-06 03:57:36 +01:00
use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
2020-05-18 21:13:27 +02:00
use Psalm\Internal\Analyzer\Statements\Expression\ExpressionIdentifier;
2018-11-06 03:57:36 +01:00
use Psalm\Internal\Analyzer\StatementsAnalyzer;
2018-01-29 00:29:38 +01:00
use Psalm\CodeLocation;
use Psalm\Context;
use Psalm\Issue\InvalidMethodCall;
use Psalm\Issue\InvalidScope;
use Psalm\Issue\NullReference;
use Psalm\Issue\PossiblyFalseReference;
use Psalm\Issue\PossiblyInvalidMethodCall;
use Psalm\Issue\PossiblyNullReference;
use Psalm\Issue\PossiblyUndefinedMethod;
use Psalm\Issue\TooFewArguments;
use Psalm\Issue\TooManyArguments;
use Psalm\Issue\UndefinedInterfaceMethod;
use Psalm\Issue\UndefinedMagicMethod;
2018-01-29 00:29:38 +01:00
use Psalm\Issue\UndefinedMethod;
use Psalm\IssueBuffer;
use Psalm\Type;
use Psalm\Type\Atomic\TNamedObject;
use function count;
use function is_string;
use function array_reduce;
2018-01-29 00:29:38 +01:00
/**
* @internal
*/
2018-11-06 03:57:36 +01:00
class MethodCallAnalyzer extends \Psalm\Internal\Analyzer\Statements\Expression\CallAnalyzer
2018-01-29 00:29:38 +01:00
{
/**
2018-11-11 18:01:14 +01:00
* @param StatementsAnalyzer $statements_analyzer
2018-01-29 00:29:38 +01:00
* @param PhpParser\Node\Expr\MethodCall $stmt
* @param Context $context
*/
public static function analyze(
2018-11-11 18:01:14 +01:00
StatementsAnalyzer $statements_analyzer,
2018-01-29 00:29:38 +01:00
PhpParser\Node\Expr\MethodCall $stmt,
Context $context,
bool $real_method_call = true
2020-05-18 21:13:27 +02:00
) : bool {
$was_inside_call = $context->inside_call;
$context->inside_call = true;
2018-11-11 18:01:14 +01:00
if (ExpressionAnalyzer::analyze($statements_analyzer, $stmt->var, $context) === false) {
2018-01-29 00:29:38 +01:00
return false;
}
2020-01-02 16:41:43 +01:00
$context->inside_call = $was_inside_call;
if (!$stmt->name instanceof PhpParser\Node\Identifier) {
$was_inside_call = $context->inside_call;
$context->inside_call = true;
2018-11-11 18:01:14 +01:00
if (ExpressionAnalyzer::analyze($statements_analyzer, $stmt->name, $context) === false) {
return false;
}
2020-01-02 16:41:43 +01:00
$context->inside_call = $was_inside_call;
}
2018-01-29 00:29:38 +01:00
if ($stmt->var instanceof PhpParser\Node\Expr\Variable) {
2018-11-11 18:01:14 +01:00
if (is_string($stmt->var->name) && $stmt->var->name === 'this' && !$statements_analyzer->getFQCLN()) {
2018-01-29 00:29:38 +01:00
if (IssueBuffer::accepts(
new InvalidScope(
'Use of $this in non-class context',
2018-11-11 18:01:14 +01:00
new CodeLocation($statements_analyzer->getSource(), $stmt)
2018-01-29 00:29:38 +01:00
),
2018-11-11 18:01:14 +01:00
$statements_analyzer->getSuppressedIssues()
2018-01-29 00:29:38 +01:00
)) {
return false;
}
}
}
2020-05-18 21:13:27 +02:00
$lhs_var_id = ExpressionIdentifier::getArrayVarId(
2018-01-29 00:29:38 +01:00
$stmt->var,
2018-11-11 18:01:14 +01:00
$statements_analyzer->getFQCLN(),
$statements_analyzer
2018-01-29 00:29:38 +01:00
);
$class_type = $lhs_var_id && $context->hasVariable($lhs_var_id, $statements_analyzer)
? $context->vars_in_scope[$lhs_var_id]
2018-01-29 00:29:38 +01:00
: null;
if ($stmt_var_type = $statements_analyzer->node_data->getType($stmt->var)) {
$class_type = $stmt_var_type;
2018-01-29 00:29:38 +01:00
} elseif (!$class_type) {
$statements_analyzer->node_data->setType($stmt, Type::getMixed());
2018-01-29 00:29:38 +01:00
}
if (!$context->check_classes) {
2020-05-19 04:57:00 +02:00
if (ArgumentsAnalyzer::analyze(
2018-11-11 18:01:14 +01:00
$statements_analyzer,
$stmt->args,
null,
null,
$context
) === false) {
return false;
}
2020-05-18 21:13:27 +02:00
return true;
2018-01-29 00:29:38 +01:00
}
2019-11-01 14:05:28 +01:00
if ($class_type
&& $stmt->name instanceof PhpParser\Node\Identifier
&& ($class_type->isNull() || $class_type->isVoid())
) {
2018-01-29 00:29:38 +01:00
if (IssueBuffer::accepts(
new NullReference(
'Cannot call method ' . $stmt->name->name . ' on null value',
new CodeLocation($statements_analyzer->getSource(), $stmt->name)
2018-01-29 00:29:38 +01:00
),
2018-11-11 18:01:14 +01:00
$statements_analyzer->getSuppressedIssues()
2018-01-29 00:29:38 +01:00
)) {
return false;
}
2020-05-18 21:13:27 +02:00
return true;
2018-01-29 00:29:38 +01:00
}
if ($class_type
&& $stmt->name instanceof PhpParser\Node\Identifier
2018-01-29 00:29:38 +01:00
&& $class_type->isNullable()
&& !$class_type->ignore_nullable_issues
) {
if (IssueBuffer::accepts(
new PossiblyNullReference(
'Cannot call method ' . $stmt->name->name . ' on possibly null value',
new CodeLocation($statements_analyzer->getSource(), $stmt->name)
2018-01-29 00:29:38 +01:00
),
2018-11-11 18:01:14 +01:00
$statements_analyzer->getSuppressedIssues()
2018-01-29 00:29:38 +01:00
)) {
// fall through
2018-01-29 00:29:38 +01:00
}
}
if ($class_type
&& $stmt->name instanceof PhpParser\Node\Identifier
2018-01-29 00:29:38 +01:00
&& $class_type->isFalsable()
&& !$class_type->ignore_falsable_issues
) {
if (IssueBuffer::accepts(
new PossiblyFalseReference(
'Cannot call method ' . $stmt->name->name . ' on possibly false value',
new CodeLocation($statements_analyzer->getSource(), $stmt->name)
2018-01-29 00:29:38 +01:00
),
2018-11-11 18:01:14 +01:00
$statements_analyzer->getSuppressedIssues()
2018-01-29 00:29:38 +01:00
)) {
// fall through
2018-01-29 00:29:38 +01:00
}
}
2018-11-11 18:01:14 +01:00
$codebase = $statements_analyzer->getCodebase();
2018-01-29 00:29:38 +01:00
$source = $statements_analyzer->getSource();
2018-01-29 00:29:38 +01:00
if (!$class_type) {
$class_type = Type::getMixed();
}
$lhs_types = $class_type->getAtomicTypes();
2020-05-19 01:10:48 +02:00
$result = new Method\AtomicMethodCallAnalysisResult();
2020-03-11 14:38:09 +01:00
$possible_new_class_types = [];
foreach ($lhs_types as $lhs_type_part) {
2020-05-19 01:10:48 +02:00
Method\AtomicMethodCallAnalyzer::analyze(
$statements_analyzer,
$stmt,
$codebase,
$context,
$lhs_type_part,
$lhs_type_part instanceof Type\Atomic\TNamedObject
|| $lhs_type_part instanceof Type\Atomic\TTemplateParam
? $lhs_type_part
: null,
false,
$lhs_var_id,
2020-03-11 14:38:09 +01:00
$result
);
if (isset($context->vars_in_scope[$lhs_var_id])
&& ($possible_new_class_type = $context->vars_in_scope[$lhs_var_id]) instanceof Type\Union
&& !$possible_new_class_type->equals($class_type)) {
$possible_new_class_types[] = $context->vars_in_scope[$lhs_var_id];
}
}
if (count($possible_new_class_types) > 0) {
$class_type = array_reduce(
$possible_new_class_types,
function (?Type\Union $type_1, Type\Union $type_2) use ($codebase): Type\Union {
if ($type_1 === null) {
return $type_2;
}
return Type::combineUnionTypes($type_1, $type_2, $codebase);
}
);
}
2020-03-11 14:38:09 +01:00
if ($result->invalid_method_call_types) {
$invalid_class_type = $result->invalid_method_call_types[0];
2020-03-11 14:38:09 +01:00
if ($result->has_valid_method_call_type || $result->has_mixed_method_call) {
if (IssueBuffer::accepts(
new PossiblyInvalidMethodCall(
'Cannot call method on possible ' . $invalid_class_type . ' variable ' . $lhs_var_id,
new CodeLocation($source, $stmt->name)
),
$statements_analyzer->getSuppressedIssues()
)) {
// keep going
}
} else {
if (IssueBuffer::accepts(
new InvalidMethodCall(
'Cannot call method on ' . $invalid_class_type . ' variable ' . $lhs_var_id,
new CodeLocation($source, $stmt->name)
),
$statements_analyzer->getSuppressedIssues()
)) {
// keep going
}
}
}
2020-03-11 14:38:09 +01:00
if ($result->non_existent_magic_method_ids) {
if ($context->check_methods) {
if (IssueBuffer::accepts(
new UndefinedMagicMethod(
2020-03-11 14:38:09 +01:00
'Magic method ' . $result->non_existent_magic_method_ids[0] . ' does not exist',
new CodeLocation($source, $stmt->name),
2020-03-11 14:38:09 +01:00
$result->non_existent_magic_method_ids[0]
),
$statements_analyzer->getSuppressedIssues()
)) {
// keep going
}
}
}
2020-03-11 14:38:09 +01:00
if ($result->non_existent_class_method_ids) {
if ($context->check_methods) {
2020-03-11 14:38:09 +01:00
if ($result->existent_method_ids || $result->has_mixed_method_call) {
if (IssueBuffer::accepts(
new PossiblyUndefinedMethod(
2020-03-11 14:38:09 +01:00
'Method ' . $result->non_existent_class_method_ids[0] . ' does not exist',
new CodeLocation($source, $stmt->name),
2020-03-11 14:38:09 +01:00
$result->non_existent_class_method_ids[0]
),
$statements_analyzer->getSuppressedIssues()
)) {
2019-02-24 07:33:25 +01:00
// keep going
}
} else {
if (IssueBuffer::accepts(
new UndefinedMethod(
2020-03-11 14:38:09 +01:00
'Method ' . $result->non_existent_class_method_ids[0] . ' does not exist',
new CodeLocation($source, $stmt->name),
2020-03-11 14:38:09 +01:00
$result->non_existent_class_method_ids[0]
),
$statements_analyzer->getSuppressedIssues()
)) {
2019-02-24 07:33:25 +01:00
// keep going
}
}
}
2020-05-18 21:13:27 +02:00
return true;
}
2020-03-11 14:38:09 +01:00
if ($result->non_existent_interface_method_ids) {
if ($context->check_methods) {
2020-03-11 14:38:09 +01:00
if ($result->existent_method_ids || $result->has_mixed_method_call) {
if (IssueBuffer::accepts(
new PossiblyUndefinedMethod(
2020-03-11 14:38:09 +01:00
'Method ' . $result->non_existent_interface_method_ids[0] . ' does not exist',
new CodeLocation($source, $stmt->name),
2020-03-11 14:38:09 +01:00
$result->non_existent_interface_method_ids[0]
),
$statements_analyzer->getSuppressedIssues()
)) {
// keep going
}
} else {
if (IssueBuffer::accepts(
new UndefinedInterfaceMethod(
2020-03-11 14:38:09 +01:00
'Method ' . $result->non_existent_interface_method_ids[0] . ' does not exist',
new CodeLocation($source, $stmt->name),
2020-03-11 14:38:09 +01:00
$result->non_existent_interface_method_ids[0]
),
$statements_analyzer->getSuppressedIssues()
)) {
// keep going
2018-01-29 00:29:38 +01:00
}
}
}
2020-05-18 21:13:27 +02:00
return true;
}
2018-01-29 00:29:38 +01:00
if ($result->too_many_arguments && $result->too_many_arguments_method_ids) {
$error_method_id = $result->too_many_arguments_method_ids[0];
if (IssueBuffer::accepts(
new TooManyArguments(
'Too many arguments for method ' . $error_method_id . ' - saw ' . count($stmt->args),
new CodeLocation($source, $stmt->name),
(string) $error_method_id
),
$statements_analyzer->getSuppressedIssues()
)) {
// fall through
}
}
if ($result->too_few_arguments && $result->too_few_arguments_method_ids) {
$error_method_id = $result->too_few_arguments_method_ids[0];
if (IssueBuffer::accepts(
new TooFewArguments(
'Too few arguments for method ' . $error_method_id . ' saw ' . count($stmt->args),
new CodeLocation($source, $stmt->name),
(string) $error_method_id
),
$statements_analyzer->getSuppressedIssues()
)) {
// fall through
}
}
2020-03-11 14:38:09 +01:00
$stmt_type = $result->return_type;
if ($stmt_type) {
$statements_analyzer->node_data->setType($stmt, $stmt_type);
}
2018-01-29 00:29:38 +01:00
2020-03-11 14:38:09 +01:00
if ($result->returns_by_ref) {
if (!$stmt_type) {
$stmt_type = Type::getMixed();
$statements_analyzer->node_data->setType($stmt, $stmt_type);
}
2020-03-11 14:38:09 +01:00
$stmt_type->by_ref = $result->returns_by_ref;
}
2018-01-29 00:29:38 +01:00
2019-02-24 07:33:25 +01:00
if ($codebase->store_node_types
&& !$context->collect_initializations
&& !$context->collect_mutations
&& $stmt_type
) {
$codebase->analyzer->addNodeType(
$statements_analyzer->getFilePath(),
$stmt->name,
2020-02-23 23:03:27 +01:00
$stmt_type->getId(),
$stmt
);
}
2018-01-29 00:29:38 +01:00
2020-03-11 14:38:09 +01:00
if (!$result->existent_method_ids) {
return self::checkMethodArgs(
null,
$stmt->args,
null,
$context,
new CodeLocation($statements_analyzer->getSource(), $stmt),
$statements_analyzer
);
}
// if we called a method on this nullable variable, remove the nullable status here
// because any further calls must have worked
if ($lhs_var_id
&& !$class_type->isMixed()
2020-03-11 14:38:09 +01:00
&& $result->has_valid_method_call_type
&& !$result->has_mixed_method_call
&& !$result->invalid_method_call_types
&& ($class_type->from_docblock || $class_type->isNullable())
&& $real_method_call
) {
$keys_to_remove = [];
2018-01-29 00:29:38 +01:00
$class_type = clone $class_type;
foreach ($class_type->getAtomicTypes() as $key => $type) {
if (!$type instanceof TNamedObject) {
$keys_to_remove[] = $key;
2018-01-29 00:29:38 +01:00
} else {
$type->from_docblock = false;
2018-01-29 00:29:38 +01:00
}
}
2018-01-29 00:29:38 +01:00
foreach ($keys_to_remove as $key) {
$class_type->removeType($key);
}
$class_type->from_docblock = false;
$context->removeVarFromConflictingClauses($lhs_var_id, null, $statements_analyzer);
2018-01-29 00:29:38 +01:00
$context->vars_in_scope[$lhs_var_id] = $class_type;
}
2020-05-18 21:13:27 +02:00
return true;
}
2018-01-29 00:29:38 +01:00
}