8118 Commits

Author	SHA1	Message	Date
ralila	84e2de888b	Conversion of Psalm\Internal\Type\TypeAlias	2021-12-14 02:08:34 +01:00
ralila	553c22f8ab	Conversion of Psalm\Internal\Type\ParseTree	2021-12-14 02:08:34 +01:00
ralila	7961130469	Conversion of Psalm\Plugin\EventHandler\Event	2021-12-14 02:08:34 +01:00
ralila	1e909d3304	Conversion of Psalm\Internal\Provider\ReturnTypeProvider	2021-12-14 02:08:12 +01:00
S.M. Ataur Rahman	f4512361b2	"No errors found!" message is now printed within a nice green block	2021-12-14 00:50:32 +06:00
orklah	fb07d5819c	Merge pull request #7141 from mathroc/fix/in-array-return-type ... in_array returns false in strict mode if types are incompatibles	2021-12-13 00:20:43 +01:00
Mathieu Rochette	39fb4222d5	in_array returns false in strict mode if types are incompatibles ... see #5552	2021-12-13 00:00:53 +01:00
adrew	de0d3a3be3	Allow IssueBuffer::remove to remove recorded issues	2021-12-13 01:42:33 +03:00
adrew	a8d23538b7	Fix closure param type inference with named params	2021-12-12 13:17:15 +03:00
Bruce Weirdan	41ca7f7f7a	Merge pull request #7136 from klimick/forbid-positional-args-after-named	2021-12-12 02:22:51 +02:00
Bruce Weirdan	e08a4f2a2a	Drop unused use	2021-12-12 01:58:45 +02:00
orklah	f79f857ded	Merge pull request #7133 from AndrolGenhald/remove-unused-suppressed ... Allow suppressing UnusedPsalmSuppress, remove unused suppressions.	2021-12-11 23:24:31 +01:00
orklah	b6638412b1	Merge pull request #7082 from dvz/fix-parser-cache-maintenance ... Fix parser cache files maintenance	2021-12-11 23:14:30 +01:00
AndrolGenhald	225af970cc	Add comments explaining condition for UnusedPsalmSuppress.	2021-12-11 16:14:25 -06:00
orklah	6632ddf884	Merge pull request #7135 from klimick/fix-closure-param-type-inference ... Fix type inference of closure params	2021-12-11 23:10:32 +01:00
orklah	50cc629a43	fix cs	2021-12-11 23:03:10 +01:00
orklah	a1268d94d5	fix some more expressions that can be replaced by getSingleAtomic	2021-12-11 22:37:44 +01:00
AndrolGenhald	684cbfeab9	Add back suppressions for undefined constants on Windows.	2021-12-11 15:37:09 -06:00
AndrolGenhald	5d09cd075d	Add another usage of getSingleAtomic.	2021-12-11 15:11:17 -06:00
adrew	6cf2e31c4a	Forbid positional arg after named arg	2021-12-11 23:37:15 +03:00
adrew	989c3ada2e	Fix type inference of closure params	2021-12-11 22:51:18 +03:00
AndrolGenhald	23b781163a	Use getSingleAtomic() instead of array_values(getAtomicTypes())[0].	2021-12-11 13:44:34 -06:00
AndrolGenhald	bfe7f96b56	Allow suppressing UnusedPsalmSuppress, remove unused suppressions.	2021-12-11 13:23:00 -06:00
orklah	0ba5b0b30a	Merge pull request #7130 from AndrolGenhald/bugfix/fix-class-property-suppression ... Class property issue suppression fixes.	2021-12-11 19:12:49 +01:00
AndrolGenhald	51d9652b70	Class property issue suppression fixes. ... Fix @psalm-suppress and @psalm-allow-private-mutation being ignored if nothing else is in the docblock. Fix @psalm-suppress not allowing extra text after the issue name. Fix PossiblyUnusedProperty and UnusedProperty suppression not working at the property level. Fix MissingPropertyType suppression not working at the property level.	2021-12-11 11:45:06 -06:00
Matthew Brown	4229045c23	Remove array properties that are never read	2021-12-11 11:55:37 -05:00
Matthew Brown	b558748db2	Detect unused properties that are written to inside arrays	2021-12-11 11:42:05 -05:00
Matthew Brown	19ae9e81d2	Remove property that is only written to but never used	2021-12-11 08:51:12 -05:00
orklah	76bb8bc655	Merge pull request #7113 from trowski/first-class-callables ... Added support for first-class callables	2021-12-10 22:40:16 +01:00
Aaron Piotrowski	3c5e99ed1e	Revert reorder of getting method return type and checking args ... Skipping checking args for first-class callables, but fixes handling of other methods.	2021-12-09 19:02:58 -06:00
orklah	ae765dfba8	Merge pull request #7054 from orklah/6933 ... fix missing case for displaying varId	2021-12-09 23:54:37 +01:00
Aaron Piotrowski	d5519fc53a	Use $stmt->args directly instead of creating new VariadicPlaceholder	2021-12-09 15:51:48 -06:00
orklah	0716dfcda0	allow Reconciler to retrieve global constant values	2021-12-09 21:27:57 +01:00
Aaron Piotrowski	1f3a37ff02	Add support for first-class callables	2021-12-09 10:54:49 -06:00
orklah	eefdb95765	Merge pull request #7093 from orklah/7090 ... don't stop analyzing array, even if we already have a type and we can't create an object like	2021-12-08 22:37:57 +01:00
orklah	604f47d52a	Merge pull request #7106 from orklah/7098 ... fix reconciliation between positive-int and inferior/superior assertions	2021-12-08 22:29:15 +01:00
Bruce Weirdan	eb2f4dca89	Merge pull request #7103 from AndrolGenhald/feature/3938-decimal-operator-overloads	2021-12-08 23:22:24 +02:00
orklah	3f46377467	don't remove literal ints if the Int type already in Union doesn't cover this specific literal	2021-12-08 22:13:54 +01:00
orklah	edeaada8af	simplify reconciliation of literal ints with inferior/superior assertions	2021-12-08 22:13:19 +01:00
orklah	be9037f7b1	fix reconciliation between positive-int and inferior/superior assertions	2021-12-08 21:38:12 +01:00
AndrolGenhald	a89e8ec28c	Fix non-empty-literal-string to behave as subtype of non-empty-string (fixes #7095).	2021-12-08 13:38:32 -06:00
AndrolGenhald	ba881c80bf	Use maybeAdd instead of accepts.	2021-12-08 12:15:32 -06:00
AndrolGenhald	b29fc6ad3c	Allow operator overloading for Decimal extension (fixes #3938).	2021-12-08 10:59:37 -06:00
Matthew Brown	8daf9c42a9	Remove useless chunk of code in ScopeAnalyzer	2021-12-07 23:42:17 -05:00
orklah	c17af4128e	don't stop analyzing array, even if we already have a type and we can't create an object like	2021-12-07 19:38:52 +01:00
Bruce Weirdan	2530b33dbd	Merge pull request #7076 from klimick/fix-generic-assertion	2021-12-07 08:08:48 +02:00
orklah	257d237192	ignore ComplexMethod: didn't see any easy refactoring	2021-12-06 20:13:33 +01:00
orklah	75312d93b1	Don't crash when checking purity of __callStatic in a trait	2021-12-06 19:00:37 +01:00
Tomasz Mlynski	348c62db94	Remove unused function reference	2021-12-06 18:25:04 +01:00
Tomasz Mlynski	e4b0b9b305	Remove redundant condition	2021-12-06 18:17:52 +01:00
Tomasz Mlynski	5c73d77f28	Remove unused methods	2021-12-06 18:16:07 +01:00
Tomasz Mlynski	7e54c5172d	Deprecate unused methods	2021-12-06 17:59:43 +01:00
Tomasz Mlynski	0fcad43581	Simplify parser cache files maintenance ... Delete files that were not modified during a no-diff run	2021-12-06 17:57:44 +01:00
Tomasz Mlynski	af23619653	Fix ParserCacheProvider::deleteOldParserCaches()	2021-12-06 17:49:40 +01:00
Ricardo Boss	2ec77fe29c	Make name property of enum cases return non-empty-strings (vimeo/psalm#6964)	2021-12-06 00:33:57 +01:00
adrew	dee3fc4358	try to fix generic assertions for list and array	2021-12-06 02:25:40 +03:00
rarila	39402c233d	Return type hints (#7065) ... Co-authored-by: ralila <>	2021-12-05 19:51:26 +02:00
orklah	f67a0ca143	Merge pull request #7068 from klimick/fix-yield ... Detect yield in array expression	2021-12-05 16:25:21 +01:00
Ricardo Boss	8a230110e8	Fix vimeo/psalm#6968	2021-12-05 15:43:38 +01:00
adrew	bc61547bce	detect yield in array expression	2021-12-05 15:33:18 +03:00
Bruce Weirdan	e9d9481ea6	Merge pull request #7060 from rarila/codingstyle-convert-fqn	2021-12-05 02:46:03 +02:00
ralila	9902898c4d	Remove unnecessary bug circumvention and generate new baseline	2021-12-05 01:15:29 +01:00
ralila	da3a691c36	Import PhpParser\Node\Expr\Closure as ClosureNode	2021-12-05 00:32:38 +01:00
ralila	81c94f12c1	Revert \Composer\Autoload\ClassLoader in other Cli\*.php	2021-12-05 00:30:13 +01:00
ralila	2d199d1f13	Revert \Composer\Autoload\ClassLoader in Cli\Psalm.php	2021-12-04 23:07:54 +01:00
ralila	8fb2e0f885	Handle some partials	2021-12-04 21:55:53 +01:00
Bruce Weirdan	14dcbc908a	Don't output console links in CI env (#7049)	2021-12-04 19:49:24 +02:00
Matthew Brown	1956b85c41	Remove always-false args (#7056)	2021-12-04 10:40:52 -05:00
ralila	f833085a15	Fix fqn usage in php-doc	2021-12-04 03:37:19 +01:00
orklah	2612f5a5f1	fix missing case for displaying varId	2021-12-03 23:46:12 +01:00
ralila	30a65685a2	Import instead of using fqn classes	2021-12-03 21:40:18 +01:00
ralila	7c32325e03	Import instead of using fqn constants	2021-12-03 21:25:22 +01:00
ralila	2a956498bf	Import instead of using fqn functions	2021-12-03 21:07:25 +01:00
ralila	711be643c6	Import instead of using fqn exceptions	2021-12-03 20:29:06 +01:00
ralila	245920e53c	Import instead of using fqn	2021-12-03 20:11:20 +01:00
orklah	826b26bf6b	fix phpdoc. The previous message was incorrect	2021-12-01 23:42:30 +01:00
orklah	a7e9eea0ca	flag usage of get_class outside class without args (#7043)	2021-12-02 00:38:45 +02:00
orklah	e90a4b4468	Merge pull request #7040 from orklah/docs-issuebuffer ... document the behavior of methods in IssueBuffer	2021-12-01 21:10:08 +01:00
orklah	fab3c94ef6	document the behavior of methods in IssueBuffer	2021-12-01 21:04:49 +01:00
Kamil Tekiela	5d99109ba9	Throw exception when baseline file is empty	2021-12-01 18:09:30 +00:00
Bruce Weirdan	28c4f86993	Merge pull request #7027 from rarila/issue-6914	2021-11-30 23:34:00 +02:00
orklah	15bc0fac1f	ignore irrelevant errors	2021-11-30 21:17:27 +01:00
Bruce Weirdan	812d62d1ce	Merge pull request #7031 from weirdan/suppress-void-progress-output	2021-11-30 21:39:24 +02:00
Bruce Weirdan	2706645126	Prevent VoidProgress from outputting anything ... Fixes vimeo/psalm#7028	2021-11-30 21:21:38 +02:00
orklah	2c6ea7c551	Merge pull request #7022 from orklah/7007 ... remove the remaining dynamic property assignment	2021-11-30 19:41:42 +01:00
ralila	98b0b052ce	Remove some now superfluous casts	2021-11-30 05:08:56 +01:00
orklah	466137a4c4	Merge pull request #7025 from orklah/6256 ... flag DeprecatedProperty on static fetch	2021-11-29 23:46:25 +01:00
orklah	328dcb093b	fix variable name	2021-11-29 23:41:47 +01:00
orklah	9de9c12851	flag DeprecatedProperty on static fetch	2021-11-29 23:32:27 +01:00
Dave Liddament	1879713dbb	Add --php-version to CLI help ... As documented here: https://psalm.dev/docs/running_psalm/configuration/#phpversion	2021-11-29 20:21:33 +00:00
Matthew Brown	175ba83332	Migrate most IssueBuffer::accepts calls to IssueBuffer::maybeAdd (#7020)	2021-11-29 14:54:17 -05:00
orklah	8ca0fc209a	remove the remaining dynamic property assignment	2021-11-29 20:12:59 +01:00
ralila	15eb8127ee	Reverse parameter list vor preg_match	2021-11-29 14:23:33 +01:00
Bruce Weirdan	99d3d5e811	Escape GHA output ... Refs Roave/BackwardCompatibilityCheck#342 Thanks @staabm for highlighting this issue.	2021-11-29 04:47:47 +02:00
Bruce Weirdan	28a75652ac	Merge pull request #6997 from zoonru/list_values_paradox	2021-11-29 00:47:12 +02:00
Daniil Gentili	925df22052	Use simplified, proper logic	2021-11-28 13:42:30 +01:00
orklah	8bc71fcf85	Merge pull request #7013 from orklah/6951 ... Allow overriding the signature type by a param docblock for promoted properties	2021-11-28 11:50:43 +01:00
orklah	a6e4230d2d	Allow overriding the signature type by a param docblock for promoted properties	2021-11-28 11:10:55 +01:00
Bruce Weirdan	806db287d2	Infer ::from() and ::tryFrom() return types on backed enums ... Fixes vimeo/psalm#6429	2021-11-28 09:47:01 +02:00
Bruce Weirdan	ac903c5634	Include enum cases in const wildcards ... Refs vimeo/psalm#6471	2021-11-28 05:49:39 +02:00
Bruce Weirdan	66eb665b55	Merge pull request #4160 from Rarst/patch-2	2021-11-28 01:33:16 +02:00
Bruce Weirdan	ec1571d261	Adjust link test to account for colors	2021-11-28 01:14:03 +02:00
Andrey Savchenko	03ae329837	Colorized file name and line in console output ... Fixes #4129	2021-11-28 01:06:21 +02:00
Bruce Weirdan	03aea28c73	Merge pull request #6995 from vimeo/enum-constants	2021-11-27 21:49:13 +02:00
Bruce Weirdan	1797716cf7	Merge pull request #7006 from weirdan/show-php-version	2021-11-27 20:21:20 +02:00
Bruce Weirdan	97445b52f3	Correctly process constant references on enum-valued variables	2021-11-27 04:32:32 +02:00
Bruce Weirdan	d19aad7db1	Display target PHP version ... Historically it was often not quite clear to users what PHP version Psalm assumes, and why. This PR addresses this issue by printing the version and where we got it from right before scanning the files.	2021-11-27 02:18:09 +02:00
Bruce Weirdan	3441197c60	Merge pull request #7004 from weirdan/drop-unused-property	2021-11-27 01:52:14 +02:00
Bruce Weirdan	2afced3101	Drop unused $fq_classlike_names property	2021-11-27 00:09:58 +02:00
orklah	72de3b66cc	Merge pull request #7003 from rarila/no-phpdoc-return-void ... Use return type hints instead of php doc "@return void"	2021-11-26 23:03:28 +01:00
ralila	7279f00e05	fix failing test	2021-11-26 21:55:30 +01:00
Daniil Gentili	2145a2cbbd	Make sure that the keyed array is actually a list after unsetting	2021-11-26 21:52:34 +01:00
Daniil Gentili	00ab986c06	Update IfElseAnalyzer.php	2021-11-26 21:47:17 +01:00
Daniil Gentili	ee8c5c9c35	Remove some array_values	2021-11-26 21:47:17 +01:00
Daniil Gentili	1129ab1475	Raise RedundantCast when using array_values on a list	2021-11-26 21:47:14 +01:00
orklah	a27e729263	Merge pull request #7002 from orklah/listkeyedarray ... Disable list flag for TKeyedArray after unset	2021-11-26 21:32:55 +01:00
ralila	fdaed941ad	use return type hints instead of php doc "@return void"	2021-11-26 20:59:41 +01:00
orklah	4f223db455	Disable list flag for TKeyedArray after unset	2021-11-26 20:52:34 +01:00
Bruce Weirdan	f215ed28d0	Drop special handling of constant references on enums ... Internally enum cases are constants, and they should be resolved as such. Fixes vimeo/psalm#6994	2021-11-26 06:00:01 +02:00
orklah	2fbad1bbeb	Merge pull request #6993 from orklah/taint-numerics ... Taint can't be transmitted through numerics nor bool	2021-11-25 23:20:38 +01:00
orklah	ab61eae5c9	Taint can't transmit through numerics nor bool	2021-11-25 22:51:35 +01:00
orklah	3bc06a8eab	Taint can't transmit through numerics nor bool	2021-11-25 22:40:01 +01:00
Kamil Tekiela	d922808e8f	Create mysqli.phpstub ... Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>	2021-11-24 22:30:22 +00:00
orklah	b4d25cbf60	Merge pull request #6984 from orklah/enumcase-in-attribute ... allow using EnumCase in an Attribute	2021-11-24 19:52:19 +01:00
orklah	049285add2	allow using EnumCase in an Attribute	2021-11-24 19:43:43 +01:00
orklah	fdf3a8dbb8	Merge pull request #6979 from orklah/6975 ... don't accept unresolved literal string as valid callable-strings	2021-11-23 21:41:04 +01:00
orklah	60f0fd13bf	Merge pull request #6981 from AlessandroMinoccheri/fix-count-for-php-7-1 ... using lenght istead of count for php 7.1 compatibility	2021-11-23 21:40:45 +01:00
AlessandroMinoccheri	ddc13a0dba	using lenght istead of count for php 7.1 compatibility	2021-11-23 21:32:55 +01:00
Paweł Tomulik	dac8c98613	attempt to fix #6973	2021-11-23 20:26:07 +01:00
orklah	b42c2814a9	Merge pull request #6971 from orklah/empty-keys ... fix counting array properties when some are Never	2021-11-23 20:11:47 +01:00
orklah	9db43cdaae	don't accept unresolved literal string as valid callable-strings	2021-11-23 19:54:09 +01:00
Paweł Tomulik	a7b9a241f3	attempt to fix #6937	2021-11-22 23:24:20 +01:00
orklah	eca56c0c1a	Merge pull request #6972 from orklah/unused-throws ... prevent Psalm from considering throwing methods as unused just because they're immutable	2021-11-22 22:00:55 +01:00
orklah	1c1e352e5f	prevent Psalm from considering throwing methods as unused just because they're immutable	2021-11-22 21:29:57 +01:00
orklah	0d47722195	fix counting array properties when some are Never	2021-11-22 21:13:25 +01:00
orklah	79fa7f5993	Merge pull request #6953 from orklah/callstatic-pure ... check __callStatic purity instead of the pseudoMethod purity	2021-11-21 23:02:07 +01:00
orklah	46139272f6	Merge pull request #6952 from orklah/null_propagation_in_return ... fix null propagation in return	2021-11-21 21:53:50 +01:00
orklah	3e56e859a9	fix inheritance	2021-11-21 21:53:24 +01:00
orklah	41fd460db5	check __callStatic purity instead of the pseudoMethod purity	2021-11-21 13:51:19 +01:00
orklah	6bdadfe0cb	fix null propagation in return	2021-11-21 13:18:26 +01:00
Sebastian Kehr	511ed99e46	expand type aliases when comparing unions	2021-11-19 14:15:38 +01:00
Maximilian Bösing	6bf02657b6	qa: ensure array_merge has at least one argument ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 21:10:20 +01:00
Maximilian Bösing	765bf93444	bugfix: apply coding standard ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 18:36:51 +01:00
Maximilian Bösing	68abcaab5c	feature: extract class constant by wildcard detection into dedicated resolver ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 18:27:19 +01:00
Maximilian Bösing	743f570f66	bugfix: remove preg_quote as that will also quote wildcard ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 18:06:39 +01:00
Maximilian Bösing	a050ff2878	bugfix: quote regular expression ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 17:56:40 +01:00
Maximilian Bösing	3e1be794c4	refactor: expand test cases and optimize handling of invalid class-constant references ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 17:56:39 +01:00
Maximilian Bösing	c6191643ab	qa: add Reconciler::RECONCILIATION_* constants ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 17:56:02 +01:00
Maximilian Bösing	49624169a5	bugfix: reconcile class-constant ... Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>	2021-11-15 17:53:26 +01:00
Bruce Weirdan	608e8d11fa	Merge pull request #6922 from weirdan/cases-references	2021-11-15 11:49:47 +02:00
Bruce Weirdan	0a9154b8bb	Allow references to enum cases in class constants	2021-11-15 05:56:09 +02:00
ralila	cf5a8edf1a	Ensure array offset exists	2021-11-15 04:22:14 +01:00
ralila	fe8f919495	Fix some CS issues	2021-11-15 04:00:38 +01:00
ralila	0d0a06e78f	Avoid empty variable names instead of filtering them later	2021-11-15 03:00:08 +01:00
ralila	4fd87f2d77	Allow a comma as separator	2021-11-15 02:59:16 +01:00
ralila	7326f3b125	Remove useless brackets	2021-11-14 23:55:32 +01:00
ralila	659abf52d0	Fix multiple traces don’t get added to the list	2021-11-14 23:55:32 +01:00
Bruce Weirdan	45e1a1c69a	Merge pull request #6850 from gharlan/hyperlink	2021-11-14 23:20:09 +02:00
Bruce Weirdan	4cab21d903	Use snake_case property name	2021-11-14 22:55:12 +02:00
Bruce Weirdan	bc604a36c1	Do not output links with --monochrome flag on	2021-11-14 22:50:08 +02:00
Bruce Weirdan	d61e31bbaf	Merge pull request #6912 from weirdan/mbstrotolower-produces-nonlowercase-strings-sometimes	2021-11-14 21:03:24 +02:00
Bruce Weirdan	d302ffba91	Drop duplicate constant	2021-11-14 05:19:20 +02:00
Bruce Weirdan	01d07f9392	Report deprecated elements	2021-11-14 04:55:28 +02:00
Bruce Weirdan	f5b71a3a5f	Infer mb_strtolower() result as string when encoding is specified ... `mb_strtolower()` may return characters we generally consider uppercase when it's given the encoding argument. This PR makes Psalm to err on the side of caution and treat the return type as `string` rather than `lowercase-string` in this case Refs vimeo/psalm#6908	2021-11-14 03:57:10 +02:00
Aaron Piotrowski	1bb204db76	Fix detecting readonly promoted property visibility	2021-11-13 12:54:15 -06:00
Aaron Piotrowski	d06510833b	Fix detection of readonly on promoted properties	2021-11-13 12:37:08 -06:00
orklah	b35b9f92a6	Merge pull request #6895 from orklah/ignore-falsable ... make ignore falsable/nullable dependent on the config	2021-11-13 11:37:57 +01:00
orklah	1464e8f91e	make ignore falsable/nullable dependent on the config	2021-11-13 11:37:22 +01:00
Ricardo Boss	4a58739e00	Fix typos in message about Attribute usage	2021-11-12 23:11:59 +01:00
Jonathan Vollebregt	f5d7f6c405	SimpleXMLIterator is not always truthy ... Fixes #6865	2021-11-12 13:49:31 +01:00
orklah	2d0758ab10	Merge pull request #6899 from pilif/fix-6887 ... don't stop processing for class usage after raising an issue	2021-11-12 09:42:49 +01:00
Philip Hofstetter	ece2bccf76	don't stop processing for class usage after raising an issue ... this fixes #6887	2021-11-12 09:24:39 +01:00
Daniil Gentili	8d20a83ed9	Use a proper assertion	2021-11-11 12:42:16 +01:00
Daniil Gentili	2bcbc2f86c	Small fix	2021-11-11 12:16:04 +01:00
Daniil Gentili	575fd1c55a	Small fixes	2021-11-11 12:05:03 +01:00
Daniil Gentili	9dd8533806	ImagickPixel::getColor return type provider	2021-11-11 11:54:30 +01:00
Bruce Weirdan	85f2083acb	Flag duplicate constants ... Fixes vimeo/psalm#6882 Addresses p1 from vimeo/psalm#6471	2021-11-11 00:44:17 +02:00
Nadyita	6b08f1741b	Fix --enable-autocomplete=false	2021-11-10 18:04:47 +01:00
Philip Hofstetter	038df9cebe	detect unevaluated inline-html code after an rearly return ... this is a followup after #6876 this fixes #6877	2021-11-10 13:11:50 +01:00
Philip Hofstetter	f407ac846a	do not treat __halt_compiler() as an expression being executed ... this fixes #6875	2021-11-10 12:45:12 +01:00
orklah	a193ec4573	Merge pull request #6874 from orklah/fix-never-combination ... fix never combination	2021-11-09 23:18:58 +01:00
orklah	830c898fec	Merge pull request #6872 from orklah/InvalidDocblockPromotedProperties ... allow signature type for promoted property as well as property docblock	2021-11-09 23:17:43 +01:00
orklah	8d22676627	fix errors	2021-11-09 22:31:40 +01:00
orklah	21591b0f2a	fix errors	2021-11-09 21:14:55 +01:00
orklah	db05dfeb4c	fix never combination	2021-11-09 20:59:49 +01:00
orklah	d409c063f3	allow signature type for promoted property as well as property docblock (that will be used for param as well)	2021-11-09 19:38:18 +01:00
Thomas Bley	ca2fe166ee	Added option to forbid eval() in codebase #6855	2021-11-07 21:06:22 +01:00
Bruce Weirdan	756be3b80c	Merge pull request #6843 from weirdan/enums-as-attributes	2021-11-07 17:53:19 +02:00
Bruce Weirdan	17ef25acd8	Merge pull request #6845 from sasezaki/cs_SelfMemberReference	2021-11-07 17:41:45 +02:00
orklah	4e6cb75094	Merge pull request #6848 from orklah/taint-comments ... Taint comments	2021-11-07 15:55:37 +01:00
Gregor Harlan	ab0049d0ff	ConsoleReport: Add links to open file in editor	2021-11-07 15:04:14 +01:00
orklah	3322801903	ignore comments after taint-sink	2021-11-07 10:17:25 +01:00
sasezaki	5a01c8d601	Added phpcs SelfMemberReference rule, and applied	2021-11-07 15:47:39 +09:00
Bruce Weirdan	68495be147	Forbid declaring enums as attributes ... This is in line with current Psalm behavior. We forbid non-instantiable classlikes as attributes, including abstract classes and classes with non-public constructors. Refs vimeo/psalm#6841	2021-11-07 01:47:11 +02:00
Bruce Weirdan	9210bbcdd4	Forbid enum instantiation ... Fixes vimeo/psalm#6837	2021-11-07 00:14:37 +02:00
orklah	b08d39e567	Merge pull request #6834 from orklah/unused-in-assert ... don't consider calls to methods with assertions as Unused	2021-11-06 22:05:34 +01:00
orklah	e28659eb6c	Merge pull request #6838 from orklah/value_and_name_enum ... better understands value and name properties for enum	2021-11-06 22:05:04 +01:00
orklah	18677bb108	better understands value and name properties for enum	2021-11-06 21:49:42 +01:00
Bruce Weirdan	0f8ef45110	Forbid properties on enums ... Fixes vimeo/psalm#6472	2021-11-06 21:57:49 +02:00
orklah	9c9669ea44	don't consider calls to methods with assertions as Unused	2021-11-06 19:54:17 +01:00
orklah	aca8e12bf9	Merge pull request #6830 from orklah/isContainedBy ... Mixed contain every types and Never is contained in every type	2021-11-05 22:05:32 +01:00
orklah	f4dcea3e57	Merge pull request #6829 from orklah/isType ... only return true in Union::is*Type* if there is a single type	2021-11-05 22:05:17 +01:00
orklah	de9ad68ad0	Mixed contain every types and Never is contained in every type	2021-11-05 21:25:23 +01:00
orklah	728175f82d	only return true in Union::is*Type* if there is a single type	2021-11-05 21:14:04 +01:00
orklah	ad57516765	create a temporary var for coalescing ternaries	2021-11-05 20:07:35 +01:00
orklah	b7834689e5	Merge pull request #6824 from orklah/session ... Makes $_SESSION possibly undefined at the source	2021-11-05 20:07:24 +01:00
orklah	33aab6cc40	allow declaring functions and classLikes after a never-returning call	2021-11-05 18:09:40 +01:00
orklah	6e5f3db06c	makes $_SESSION possibly undefined	2021-11-04 22:45:46 +01:00
orklah	fffef80ec1	makes $_SESSION possibly undefined	2021-11-04 22:38:31 +01:00
orklah	915278e253	Merge pull request #6823 from orklah/variable_class ... allow assertion to work on $var::class	2021-11-04 20:54:59 +01:00
orklah	834d831915	allow assertion to work on $var::class	2021-11-04 20:44:42 +01:00
orklah	5282e4728b	allow assertion to work on $var::class	2021-11-04 20:33:30 +01:00
orklah	cd74f665dc	Merge pull request #6813 from orklah/intTaint ... don't register taints for numeric variables	2021-11-04 15:30:52 +01:00
orklah	e6dccaa07c	Merge pull request #6809 from orklah/binaryOpTaint ... don't taint the result of most binary operations	2021-11-04 13:18:07 +01:00
orklah	bf993452a8	Merge pull request #6810 from orklah/castArrayTaints ... Array cast pass taints	2021-11-04 13:17:20 +01:00
orklah	c2b14e2f39	Merge pull request #6812 from orklah/shell_exec_taint ... backticks shell_exec taint	2021-11-04 13:16:53 +01:00
Bruce Weirdan	6610a2f918	Improve Github Actions output ... * Use issue type in title * Also provide issue type and location in the (use-visible) error message Fixes vimeo/psalm#6817	2021-11-04 03:03:25 +02:00
orklah	3503f198a6	add deprecated tags to the array	2021-11-04 00:39:09 +01:00
orklah	6e49c61fd0	fix comment	2021-11-04 00:31:22 +01:00
orklah	9fb74a4f28	exclude Plus on arrays too	2021-11-04 00:30:09 +01:00
orklah	3b01713257	don't taint the result of most binary operations	2021-11-04 00:30:09 +01:00
orklah	24137bdbad	Array cast pass taints	2021-11-04 00:29:36 +01:00
orklah	eca530d792	don't register taints for numeric variables	2021-11-04 00:29:07 +01:00
orklah	ff83c498a7	fix CS	2021-11-04 00:28:40 +01:00
orklah	fbe305e5bb	detect taint in backticks	2021-11-04 00:28:40 +01:00
Alexander Wühr	2d91b90690	Add pcntl_alarm to the list of impure functions	2021-11-03 10:16:10 +01:00
sasezaki	e3c6464a91	accept ::class constant strings for literal argument	2021-11-03 13:44:14 +09:00
Bruce Weirdan	0cdb0dc04a	Merge pull request #6768 from zoonru/psalm-self-out-templates	2021-11-02 21:41:16 +02:00
orklah	96ae8e7600	Merge pull request #6793 from orklah/unevaluatedCode ... emit UnevaluatedCode after exit or never returning functionlike	2021-11-01 23:41:36 +01:00
orklah	68a4f9e930	emit UnevaluatedCode after exit or never returning functionlike	2021-11-01 22:13:29 +01:00
Bruce Weirdan	81ca05f3ab	Merge pull request #6790 from orklah/fix_yield	2021-11-01 20:25:54 +02:00
orklah	af129f8851	detect yield in new	2021-11-01 19:04:37 +01:00
Bruce Weirdan	ac098a52da	Allow to forbid exit() and die()	2021-10-31 03:02:16 +03:00
Alexey Borzov	91ec5712ad	Add a means to switch return types based on PHP_VERSION_ID ... As suggested in vimeo/psalm#6755	2021-10-29 22:19:38 +03:00
Bruce Weirdan	8c33b21261	Merge pull request #6776 from orklah/double-autoload-call	2021-10-29 11:25:14 +03:00
orklah	61a7cbe9c5	Merge pull request #6764 from orklah/promoted-property-docblock ... allow documenting promoted properties with @var	2021-10-28 22:19:42 +02:00
orklah	67a3f3cd5c	fix spacing	2021-10-28 22:11:30 +02:00
orklah	d330b340d2	try without second call	2021-10-28 22:07:50 +02:00
orklah	067f8375cf	replace exception by InvalidDocblock	2021-10-28 22:05:43 +02:00
orklah	9823e87b80	Merge pull request #6774 from orklah/reconcileFalsyOrEmpty ... fix local variable defined too early	2021-10-28 21:47:17 +02:00
orklah	b9effdb28a	Merge pull request #6742 from zoonru/fix_fewer_template_parameters ... Fix template parameter collection for child classes with fewer parameters (fixes #6734)	2021-10-28 20:06:11 +02:00
orklah	a7c44a1a19	fix local variable defined too early	2021-10-28 19:33:27 +02:00
Daniil Gentili	597487c4c9	Assert that $lhs_var_id is defined	2021-10-28 10:50:43 +02:00
Daniil Gentili	5fae548e62	Add template support to @psalm-self-out	2021-10-28 10:44:37 +02:00
orklah	e17ca1ba10	fix CS/test	2021-10-27 22:45:16 +02:00
orklah	9b7eabe17f	allow documenting promoted properties with @var	2021-10-27 22:35:21 +02:00
orklah	4783149773	deprecate TEmpty	2021-10-27 21:26:31 +02:00
Daniil Gentili	9c59550e15	Fully fix recursive template parameter resolution	2021-10-27 10:58:33 +02:00
orklah	dc2ac427ca	Don't remove a type because they have a common parent	2021-10-26 22:54:55 +02:00
orklah	6fba5eb554	Merge pull request #6738 from orklah/generator_and_iterator ... don't use is_a with user classes	2021-10-26 19:28:17 +02:00
orklah	70175d8fd2	Merge pull request #6744 from orklah/dont_assert_mixed ... Don't assert mixed type	2021-10-26 19:23:13 +02:00
orklah	e8e2624c5f	Don't assert mixed type	2021-10-26 19:12:13 +02:00
Daniil Gentili	c0e6f93deb	Fix template parameter collection for child classes with fewer parameters	2021-10-26 13:06:45 +02:00
Bruce Weirdan	4b0c8806a7	Merge pull request #6739 from orklah/instanceof_notliteral	2021-10-25 23:45:17 +03:00
orklah	caf9602cb8	don't emit redundant error when checking a named type against itself	2021-10-25 19:02:07 +02:00
orklah	86a9e5c13a	fix CS	2021-10-25 18:29:44 +02:00
orklah	dcd3601645	don't use is_a with user classes	2021-10-25 18:29:09 +02:00
orklah	9fb959150a	Merge pull request #6730 from orklah/int-template-arithmetics ... don't emit issues when doing arithmetics on int templates	2021-10-24 20:39:54 +02:00
orklah	0161dedcdb	fix	2021-10-24 19:53:22 +02:00
orklah	2c5cec4a05	fix	2021-10-24 19:48:28 +02:00
orklah	af918a95a2	don't emit issues when doing arithmetics on int templates	2021-10-24 19:30:39 +02:00
orklah	d99f300043	fix concat	2021-10-24 19:15:18 +02:00
orklah	90d6239d74	strlen of strtolower of string is not always true	2021-10-24 18:40:13 +02:00
orklah	e33492398b	Merge pull request #6726 from orklah/crash_intrange ... Don't crash on falsy with int ranges	2021-10-24 14:29:22 +02:00
orklah	c38139a87c	Don't crash on falsy with int ranges	2021-10-24 13:59:21 +02:00
orklah	68528985d6	Merge pull request #6724 from orklah/impure_callstatic ... flag impure calls made through __callstatic	2021-10-24 10:30:56 +02:00
orklah	a0681a4498	flag impure calls made through __callstatic	2021-10-24 09:55:40 +02:00
orklah	0339815070	fix type leaking when using ternaries	2021-10-23 18:58:05 +02:00
orklah	307635fca5	Merge pull request #6721 from orklah/ftp_pasv ... ftp_pasv is impure	2021-10-23 15:23:37 +02:00
orklah	fbd861c01e	ftp_pasv is impure	2021-10-23 15:17:49 +02:00
orklah	b63d877f48	Merge pull request #6720 from orklah/loop-template-regression ... Don't refine empty/falsy assertions on templates inside loops	2021-10-23 14:31:10 +02:00
orklah	78a4c78187	Merge pull request #6718 from orklah/5651 ... fix literal string access on a non empty array	2021-10-23 12:11:39 +02:00
orklah	fb5a652e18	Don't refine empty/falsy assertions on templates inside loops	2021-10-23 11:17:47 +02:00
orklah	2cc5c555c2	fix literal string access on a non empty array	2021-10-22 18:17:08 +02:00
orklah	7bb37af1e5	Merge pull request #6714 from orklah/emptyorfalsy ... More refactoring around Empty/falsy reconciliation	2021-10-21 23:40:01 +02:00
orklah	2d90631c87	Merge pull request #6689 from orklah/traversable&array ... only fuse array & Traversable with phpstorm generics	2021-10-21 22:38:59 +02:00
orklah	1b9f84970d	Merge pull request #6716 from orklah/fatal ... fix Uncaught ValueError: strrpos()	2021-10-21 21:36:53 +02:00
orklah	fdd20b8698	fix Uncaught ValueError: strrpos(): Argument #3 ($offset) must be contained in argument #1 ($haystack) in /var/www/html/vendor/vimeo/psalm/src/Psalm/CodeLocation.php:301	2021-10-21 21:27:38 +02:00
orklah	1c0b802abb	fix regression	2021-10-21 21:10:12 +02:00
orklah	b43fd0037f	fix CS	2021-10-21 19:14:38 +02:00
orklah	513ae016f9	consistency	2021-10-21 19:14:38 +02:00
orklah	5f17ea9b63	improve empty/falsy	2021-10-21 19:14:36 +02:00
orklah	4b0e3d0c06	improve empty/falsy	2021-10-21 19:14:02 +02:00
orklah	31bbd5a967	Merge pull request #6707 from orklah/!falsy_on_empty-string ... improve falsy on non-empty-string	2021-10-20 23:18:12 +02:00
orklah	7ce0c3a6e3	improve falsy on non-empty-string	2021-10-20 22:31:03 +02:00
orklah	1f02795e42	fix missing implicit __toString	2021-10-20 19:54:32 +02:00
orklah	cf8e443d10	use better issue types	2021-10-20 07:32:08 +02:00
orklah	4755131585	more consistency	2021-10-20 07:32:04 +02:00
orklah	3866c6b529	new truthy type	2021-10-20 07:31:11 +02:00
orklah	8bcdd6e339	new truthy type	2021-10-20 07:31:11 +02:00
orklah	f5b4cb664c	new falsy type	2021-10-20 07:31:11 +02:00
orklah	1d59d2cd00	more consistency	2021-10-20 07:31:11 +02:00
orklah	9b8e483a4c	improve empty/falsy reconciliation	2021-10-20 07:31:11 +02:00
orklah	23a9896eda	Merge pull request #6693 from orklah/clauses ... Remove hasPossiblyNumericType	2021-10-20 07:08:25 +02:00
orklah	c7ea446405	remove unused function	2021-10-19 22:20:10 +02:00
orklah	dc0b2074a4	test without weird function	2021-10-19 22:12:20 +02:00
orklah	37f1f87052	Merge pull request #6690 from orklah/simplexmliterator ... add SimpleXMLIterator to universalObjectCrates	2021-10-19 18:36:02 +02:00
orklah	1288d49130	add SimpleXMLIterator to universalObjectCrates	2021-10-18 21:59:17 +02:00
orklah	ec59876935	only fuse array & Traversable with phpstorm generics	2021-10-18 21:27:11 +02:00
orklah	f7a63361ad	Merge pull request #6679 from SCIF/bugfix-5694-arrayfilter ... Improve handling of positive ints by array_filter()	2021-10-17 23:20:26 +02:00
Aleksandr Zhuravlev	b664850cdc	Added support of asserting properties of objects out of scope	2021-10-17 21:29:25 +13:00
Aleksandr Zhuravlev	978d9ec774	Improve handling of positive ints by array_filter()	2021-10-16 20:47:22 +13:00
orklah	7a47ebfcd6	fix	2021-10-16 00:26:00 +02:00
orklah	56c73142d6	don't emit InvalidReturnType when return type was inferred to never	2021-10-16 00:15:17 +02:00
orklah	1aad830392	Merge pull request #6654 from zoonru/fixes ... Fix manipulation of intersection types, arrow functions, foreign static types, parameter static types, T|false|null unions.	2021-10-15 23:41:24 +02:00
Bruce Weirdan	c556920352	Revert "Merge remote-tracking branch 'upstream/master' into test5" ... This reverts commit 043a0262f7, reversing changes made to cc4c29837d.	2021-10-16 00:20:38 +03:00
orklah	043a0262f7	Merge remote-tracking branch 'upstream/master' into test5	2021-10-15 22:37:07 +02:00
orklah	99d8f92e4f	what would that do?	2021-10-15 22:33:04 +02:00
orklah	b8a2ba251f	Merge pull request #6672 from orklah/phpstorm-generics ... prevent phpstorm generics from touching to signature types	2021-10-14 21:25:36 +02:00
orklah	8a770a1003	fix CS	2021-10-14 21:09:30 +02:00
orklah	a1b1080c4e	prevent phpstorm generics from touching to signature types	2021-10-14 21:04:53 +02:00
orklah	110f2b4822	Merge pull request #6658 from fluffycondor/method-annotation-parsing-fix ... Fix @psalm-method annotation parsing	2021-10-14 17:36:42 +02:00
orklah	859966defe	Merge pull request #6669 from orklah/8.1-2 ... allow Psalm to choose PHP8.1 if it's the lower PHP version allowed	2021-10-14 17:35:46 +02:00
orklah	ef7e6cdf01	allow Psalm to choose PHP8.1 if it's the lower PHP version allowed	2021-10-14 16:54:27 +02:00
Semyon	0f6acacf31	Make psalm- prefix optional on @psalm-method annotation	2021-10-14 17:07:00 +03:00
Daniil Gentili	244a90ca4f	Fix #6665	2021-10-14 10:56:54 +02:00
orklah	75c3f8716a	Merge pull request #6652 from orklah/is_a_stub ... stub for is_a	2021-10-14 00:13:13 +02:00
orklah	64df00baba	Merge pull request #6660 from orklah/cleanup4 ... Code trimming	2021-10-14 00:12:21 +02:00
orklah	ae193ca4da	replace elvis operator by coalesce operator when applicable	2021-10-13 20:16:06 +02:00
orklah	dbc6f503b1	use of strtolower only once	2021-10-13 20:16:06 +02:00
Semyon	531aafc0c6	Add one more check is anything captured, it doesn't look like -1 actually expects	2021-10-13 18:06:10 +03:00
Semyon	a109d1ab27	Code style	2021-10-13 17:49:42 +03:00
Semyon	89f72dd9e9	Add check is anything captured	2021-10-13 17:32:40 +03:00
Semyon	a8d34c00cd	Fix psalm-method annotation parsing	2021-10-13 17:20:36 +03:00
orklah	e17290a9bc	Merge pull request #6613 from orklah/string-unpacking ... String unpacking	2021-10-13 15:18:11 +02:00
orklah	91c3d788f6	Merge pull request #6656 from orklah/setAttribute ... use Attribute feature of PHP-Parser to avoid dealing with dynamic properties	2021-10-13 14:46:22 +02:00
Daniil Gentili	24f1b60e53	Fix nullable unions	2021-10-13 14:05:48 +02:00
orklah	bee5b69f7f	use Attribute feature of PHP-Parser to avoid dealing with dynamic properties	2021-10-13 13:27:56 +02:00
Daniil Gentili	a9ba848503	Fix	2021-10-13 11:38:42 +02:00
Daniil Gentili	ce60fa2151	Cleanup	2021-10-13 11:26:01 +02:00
orklah	9bb731182a	reintroduce errors for older versions	2021-10-13 11:22:40 +02:00
orklah	6e7aafe9b8	better behaviour in SimpleTypeInferer	2021-10-13 11:22:40 +02:00
orklah	66bbcc212c	remove unneeded argument	2021-10-13 11:22:40 +02:00
orklah	690c24f824	array unpacking with strings	2021-10-13 11:22:40 +02:00
Daniil Gentili	b6e7201b5a	Forbid static in parameter typehint	2021-10-13 11:22:33 +02:00
Daniil Gentili	1c99af205b	Fix manipulation of intersection types, arrow functions, foreign static types, T|false|null unions.	2021-10-13 11:13:43 +02:00
Daniil Gentili	1574751aef	Fix docblock manipulator for arrow closures	2021-10-13 10:23:06 +02:00
Daniil Gentili	1cca3c0546	Hotfix	2021-10-13 10:23:06 +02:00
orklah	e7cd2eac0a	Merge pull request #6641 from orklah/weird-assertion-count ... Union::getAssertionString with multiple types	2021-10-13 08:15:28 +02:00
orklah	78c4d9def7	fix	2021-10-12 22:16:35 +02:00
orklah	1efe272aed	stub for is_a	2021-10-12 22:12:51 +02:00
orklah	233fe11d12	SimpleXMLElement is not always truthy	2021-10-12 15:46:02 +02:00
orklah	c6fb81007c	Merge pull request #6629 from orklah/loops-tweaking ... tweaking with loops	2021-10-11 20:45:54 +02:00
orklah	af414ffe59	Merge pull request #6642 from orklah/inside-conditional ... Inside conditional	2021-10-11 20:45:14 +02:00
orklah	911076939c	Merge pull request #6628 from orklah/phpparser2 ... Php-Parser 4.13	2021-10-11 20:42:32 +02:00
orklah	b54dddf484	Merge pull request #6643 from orklah/never-closure ... infer never on closures(and more?)	2021-10-11 20:42:02 +02:00
orklah	21456b85b1	add Never for throws. Add Never only if at top level	2021-10-11 19:35:18 +02:00
orklah	f9377c53fc	infer never on closures(and more?)	2021-10-11 18:52:26 +02:00
orklah	c4ebc34695	suppress or use the return type	2021-10-11 17:27:52 +02:00
orklah	9e7d3a4cd6	sets the inside_conditional flag after creating another context from it	2021-10-11 16:38:39 +02:00